Address codereview comments

Author: AmrDeveloper

clang/include/clang/CIR/Dialect/IR/CIRAttrs.td

@@ -280,7 +280,8 @@ def ConstPtrAttr : CIR_Attr<"ConstPtr", "ptr", [TypedAttrInterface]> {
 // ConstComplexAttr
 //===----------------------------------------------------------------------===//
 
-def ConstComplexAttr : CIR_Attr<"ConstComplex", "const_complex", [TypedAttrInterface]> {
+def ConstComplexAttr : CIR_Attr<"ConstComplex", "const_complex",
+                                [TypedAttrInterface]> {
   let summary = "An attribute that contains a constant complex value";
   let description = [{
     The `#cir.const_complex` attribute contains a constant value of complex number

clang/lib/CIR/CodeGen/CIRGenTypes.cpp

@@ -386,7 +386,7 @@ mlir::Type CIRGenTypes::convertType(QualType type) {
   }
 
   case Type::Complex: {
-    const ComplexType *ct = cast<ComplexType>(ty);
+    const auto *ct = mlir::cast<clang::ComplexType>(ty);
     mlir::Type elementTy = convertType(ct->getElementType());
     resultType = cir::ComplexType::get(elementTy);
     break;

clang/lib/CIR/Dialect/IR/CIRDialect.cpp

@@ -234,7 +234,8 @@ static LogicalResult checkConstantTypes(mlir::Operation *op, mlir::Type opType,
     if (isa<cir::RecordType, cir::ArrayType, cir::VectorType, cir::ComplexType>(
             opType))
       return success();
-    return op->emitOpError("zero expects struct or array type");
+    return op->emitOpError(
+        "zero expects struct, array, vector or complex type");
   }
 
   if (mlir::isa<cir::BoolAttr>(attrType)) {

clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp

@@ -237,8 +237,8 @@ mlir::Value CIRAttrToValue::visitCirAttr(cir::FPAttr fltAttr) {
 /// ConstComplexAttr visitor.
 mlir::Value CIRAttrToValue::visitCirAttr(cir::ConstComplexAttr complexAttr) {
   auto complexType = mlir::cast<cir::ComplexType>(complexAttr.getType());
-  auto complexElemTy = complexType.getElementType();
-  auto complexElemLLVMTy = converter->convertType(complexElemTy);
+  mlir::Type complexElemTy = complexType.getElementType();
+  mlir::Type complexElemLLVMTy = converter->convertType(complexElemTy);
 
   mlir::Attribute components[2];
   if (const auto intType = mlir::dyn_cast<cir::IntType>(complexElemTy)) {