Revert "[mlir] Fix '-Wtemplate-id-cdtor'. NFC"

kparzysz · kparzysz · commit 58cb4873f965 · 2025-12-08T10:48:53.000-06:00
This reverts commit fccb65e. It breaks pre-merge CI: ``` 2025-12-08T16:35:11.7239054Z /home/gha/actions-runner/_work/llvm-project/llvm-project/mlir/lib/Pass/PassRegistry.cpp:439:37: error: ISO C++ requires the name after '::~' to be found in the same scope as the name before '::~' [-Werror,-Wdtor-name] 2025-12-08T16:35:11.7240458Z 439 | llvm::cl::OptionValue<OpPassManager>::~OptionValue() = default; 2025-12-08T16:35:11.7241014Z | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~ 2025-12-08T16:35:11.7241494Z | ::OptionValue 2025-12-08T16:35:11.7241903Z 1 error generated. ```
diff --git a/mlir/lib/Pass/PassRegistry.cpp b/mlir/lib/Pass/PassRegistry.cpp
@@ -436,7 +436,7 @@ llvm::cl::OptionValue<OpPassManager>::operator=(
   return *this;
 }
 
-llvm::cl::OptionValue<OpPassManager>::~OptionValue() = default;
+llvm::cl::OptionValue<OpPassManager>::~OptionValue<OpPassManager>() = default;
 
 void llvm::cl::OptionValue<OpPassManager>::setValue(
     const OpPassManager &newValue) {

Original file line number	Diff line number	Diff line change
`@@ -436,7 +436,7 @@ llvm::cl::OptionValue<OpPassManager>::operator=(`
`436`	`436`	`return *this;`
`437`	`437`	`}`
`438`	`438`
`439`		`-llvm::cl::OptionValue<OpPassManager>::~OptionValue() = default;`
	`439`	`+llvm::cl::OptionValue<OpPassManager>::~OptionValue<OpPassManager>() = default;`
`440`	`440`
`441`	`441`	`void llvm::cl::OptionValue<OpPassManager>::setValue(`
`442`	`442`	`const OpPassManager &newValue) {`