Skip to content

Commit 58f0e99

Browse files
committed
move error
Signed-off-by: Sidorov, Dmitry <[email protected]>
1 parent b1d74e0 commit 58f0e99

File tree

3 files changed

+5
-16
lines changed

3 files changed

+5
-16
lines changed

llvm/lib/Target/SPIRV/SPIRVBuiltins.cpp

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1048,19 +1048,6 @@ static bool buildBindlessImageINTELInst(const SPIRV::IncomingCall *Call,
10481048
unsigned Opcode,
10491049
MachineIRBuilder &MIRBuilder,
10501050
SPIRVGlobalRegistry *GR) {
1051-
const SPIRV::DemangledBuiltin *Builtin = Call->Builtin;
1052-
const auto *ST =
1053-
static_cast<const SPIRVSubtarget *>(&MIRBuilder.getMF().getSubtarget());
1054-
if ((Opcode == SPIRV::OpConvertHandleToImageINTEL ||
1055-
Opcode == SPIRV::OpConvertHandleToSamplerINTEL ||
1056-
Opcode == SPIRV::OpConvertHandleToSampledImageINTEL) &&
1057-
!ST->canUseExtension(SPIRV::Extension::SPV_INTEL_bindless_images)) {
1058-
std::string DiagMsg = std::string(Builtin->Name) +
1059-
": the builtin requires the following SPIR-V "
1060-
"extension: SPV_INTEL_bindless_images";
1061-
report_fatal_error(DiagMsg.c_str(), false);
1062-
}
1063-
10641051
// Generate SPIRV instruction accordingly.
10651052
if (Call->isSpirvOp())
10661053
return buildOpFromWrapper(MIRBuilder, Opcode, Call,

llvm/lib/Target/SPIRV/SPIRVModuleAnalysis.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1681,8 +1681,9 @@ void addInstrRequirements(const MachineInstr &MI,
16811681
case SPIRV::OpConvertHandleToSamplerINTEL:
16821682
case SPIRV::OpConvertHandleToSampledImageINTEL:
16831683
if (!ST.canUseExtension(SPIRV::Extension::SPV_INTEL_bindless_images))
1684-
report_fatal_error("Intel bindless images handles require the following "
1685-
"SPIR-V extension: SPV_INTEL_bindless_images",
1684+
report_fatal_error("OpConvertHandleTo[Image/Sampler/SampledImage]INTEL "
1685+
"instructions require the following SPIR-V extension: "
1686+
"SPV_INTEL_bindless_images",
16861687
false);
16871688
Reqs.addExtension(SPIRV::Extension::SPV_INTEL_bindless_images);
16881689
Reqs.addCapability(SPIRV::Capability::BindlessImagesINTEL);

llvm/test/CodeGen/SPIRV/extensions/SPV_INTEL_bindless_images/bindless_images_generic.ll

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
; RUN: not llc -O0 -mtriple=spirv64-unknown-unknown %s -o %t.spvt 2>&1 | FileCheck %s --check-prefix=CHECK-ERROR
22
; RUN: llc -O0 -mtriple=spirv64-unknown-unknown --spirv-ext=+SPV_INTEL_bindless_images %s -o - | FileCheck %s
33

4-
; CHECK-ERROR: LLVM ERROR: __spirv_ConvertHandleToImageINTEL: the builtin requires the following SPIR-V extension: SPV_INTEL_bindless_images
4+
; CHECK-ERROR: LLVM ERROR: OpConvertHandleTo[Image/Sampler/SampledImage]INTEL instruction
5+
; CHECK-ERROR-SAME: require the following SPIR-V extension: SPV_INTEL_bindless_images
56

67
; CHECK: OpCapability BindlessImagesINTEL
78
; CHECK: OpExtension "SPV_INTEL_bindless_images"

0 commit comments

Comments
 (0)