Skip to content

Commit 58fc9bb

Browse files
fixup! [lldb] improve the heuristics for checking if a terminal supports Unicode
1 parent 41676ba commit 58fc9bb

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

lldb/include/lldb/Host/Terminal.h

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -174,10 +174,11 @@ class TerminalState {
174174
/// The value is cached after the first computation.
175175
///
176176
/// On POSIX systems, we check if the LANG environment variable contains the
177-
/// substring "UTF-8";
177+
/// substring "UTF-8", case insensitive.
178178
///
179-
/// On Windows, we check that we are running from the Windows Terminal
180-
/// application.
179+
/// On Windows, we always return true since we use the `WriteConsoleW` API
180+
/// internally. Note that the default Windows codepage (437) does not support
181+
/// all Unicode characters. This function does not check the codepage.
181182
bool TerminalSupportsUnicode();
182183

183184
} // namespace lldb_private

0 commit comments

Comments
 (0)