Skip to content

Commit 594345f

Browse files
committed
Refactor
1 parent 7015aa9 commit 594345f

File tree

1 file changed

+0
-45
lines changed

1 file changed

+0
-45
lines changed

llvm/unittests/ExecutionEngine/Orc/LibraryResolverTest.cpp

Lines changed: 0 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -331,9 +331,6 @@ TEST_F(LibraryResolverIT, EnumerateSymbols_ExportsOnly_DefaultFlags) {
331331
EXPECT_FALSE(any_of(seen, [&](const std::string &s) {
332332
return matchesEitherUnderscore(s, "sayB");
333333
}));
334-
EXPECT_FALSE(any_of(seen, [&](const std::string &s) {
335-
return matchesEitherUnderscore(s, "sayZ");
336-
}));
337334
}
338335

339336
TEST_F(LibraryResolverIT, EnumerateSymbols_IncludesUndefineds) {
@@ -363,9 +360,6 @@ TEST_F(LibraryResolverIT, EnumerateSymbols_IncludesUndefineds) {
363360
EXPECT_TRUE(any_of(seen, [&](const std::string &s) {
364361
return matchesEitherUnderscore(s, "sayB");
365362
}));
366-
EXPECT_TRUE(any_of(seen, [&](const std::string &s) {
367-
return matchesEitherUnderscore(s, "sayZ");
368-
}));
369363
}
370364

371365
// Full resolution via LibraryResolutionDriver/LibraryResolver ---
@@ -423,45 +417,6 @@ TEST_F(LibraryResolverIT, DriverResolvesSymbolsToCorrectLibraries) {
423417
EXPECT_TRUE(CallbackRan);
424418
}
425419

426-
TEST_F(LibraryResolverIT, EnumerateSymbols_RespectsAllFilterCombinations) {
427-
const std::string libC = lib("C");
428-
429-
// 1. Default (exports only)
430-
SymbolEnumeratorOptions def = SymbolEnumeratorOptions::defaultOptions();
431-
std::vector<std::string> exports;
432-
SymbolEnumerator::enumerateSymbols(
433-
libC,
434-
[&](llvm::StringRef sym) {
435-
exports.push_back(sym.str());
436-
return EnumerateResult::Continue;
437-
},
438-
def);
439-
440-
EXPECT_TRUE(any_of(exports, [&](const std::string &s) {
441-
return matchesEitherUnderscore(s, "sayC");
442-
}));
443-
EXPECT_FALSE(any_of(exports, [&](const std::string &s) {
444-
return matchesEitherUnderscore(s, "sayA");
445-
}));
446-
447-
// 2. Include undefined
448-
SymbolEnumeratorOptions includeUndef = def;
449-
includeUndef.FilterFlags &= ~SymbolEnumeratorOptions::IgnoreUndefined;
450-
std::vector<std::string> allSyms;
451-
SymbolEnumerator::enumerateSymbols(
452-
libC,
453-
[&](llvm::StringRef sym) {
454-
allSyms.push_back(sym.str());
455-
return EnumerateResult::Continue;
456-
},
457-
includeUndef);
458-
459-
EXPECT_TRUE(any_of(allSyms, [&](const std::string &s) {
460-
return matchesEitherUnderscore(s, "sayA");
461-
}));
462-
EXPECT_TRUE(allSyms.size() > exports.size());
463-
}
464-
465420
// stress SymbolQuery with the real resolve flow
466421
// And resolve libC dependency libA, libB, libZ ---
467422
TEST_F(LibraryResolverIT, ResolveManySymbols) {

0 commit comments

Comments
 (0)