Address comments

Author: Groverkss

mlir/lib/Dialect/Vector/IR/VectorOps.cpp

@@ -6594,24 +6594,26 @@ bool ConstantMaskOp::isAllOnesMask() {
   return true;
 }
 
-static Attribute createBoolSplat(ShapedType ty, bool x) {
-  return SplatElementsAttr::get(ty, BoolAttr::get(ty.getContext(), x));
-}
-
 OpFoldResult ConstantMaskOp::fold(FoldAdaptor adaptor) {
   ArrayRef<int64_t> bounds = getMaskDimSizes();
   ArrayRef<int64_t> vectorSizes = getVectorType().getShape();
+
+  auto createBoolSplat = [&](bool x) {
+    return SplatElementsAttr::get(getVectorType(),
+                                  BoolAttr::get(getContext(), x));
+  };
+
   // Check the corner case of 0-D vectors first.
-  if (vectorSizes.size() == 0) {
+  if (vectorSizes.empty()) {
     assert(bounds.size() == 1 && "invalid sizes for zero rank mask");
-    return createBoolSplat(getVectorType(), bounds[0] == 1);
+    return createBoolSplat(bounds[0] == 1);
   }
   // Fold vector.constant_mask to splat if possible.
   if (bounds == vectorSizes)
-    return createBoolSplat(getVectorType(), true);
+    return createBoolSplat(true);
   if (llvm::all_of(bounds, [](int64_t x) { return x == 0; }))
-    return createBoolSplat(getVectorType(), false);
-  return {};
+    return createBoolSplat(false);
+  return OpFoldResult();
 }
 
 //===----------------------------------------------------------------------===//