Skip to content

Commit 5991abe

Browse files
Minor unrelated doc and formatting improvements (NFC).
This commit fixes three occurrences of the same grammar issue in some comment and adds a clang-format suppression for a specific ordering of includes. Signed-off-by: Ingo Müller <[email protected]>
1 parent b1d185b commit 5991abe

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

mlir/include/mlir/Bindings/Python/NanobindAdaptors.h

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,10 @@
2323

2424
#include "mlir-c/Diagnostics.h"
2525
#include "mlir-c/IR.h"
26+
// clang-format off
2627
#include "mlir/Bindings/Python/Nanobind.h"
2728
#include "mlir-c/Bindings/Python/Interop.h" // This is expected after nanobind.
29+
// clang-format on
2830
#include "llvm/ADT/Twine.h"
2931

3032
// Raw CAPI type casters need to be declared before use, so always include them
@@ -435,7 +437,7 @@ class mlir_attribute_subclass : public pure_subclass {
435437
const nanobind::object &superCls,
436438
GetTypeIDFunctionTy getTypeIDFunction = nullptr)
437439
: pure_subclass(scope, typeClassName, superCls) {
438-
// Casting constructor. Note that it hard, if not impossible, to properly
440+
// Casting constructor. Note that it is hard, if not impossible, to properly
439441
// call chain to parent `__init__` in nanobind due to its special handling
440442
// for init functions that don't have a fully constructed self-reference,
441443
// which makes it impossible to forward it to `__init__` of a superclass.
@@ -516,7 +518,7 @@ class mlir_type_subclass : public pure_subclass {
516518
const nanobind::object &superCls,
517519
GetTypeIDFunctionTy getTypeIDFunction = nullptr)
518520
: pure_subclass(scope, typeClassName, superCls) {
519-
// Casting constructor. Note that it hard, if not impossible, to properly
521+
// Casting constructor. Note that it is hard, if not impossible, to properly
520522
// call chain to parent `__init__` in nanobind due to its special handling
521523
// for init functions that don't have a fully constructed self-reference,
522524
// which makes it impossible to forward it to `__init__` of a superclass.
@@ -598,7 +600,7 @@ class mlir_value_subclass : public pure_subclass {
598600
IsAFunctionTy isaFunction,
599601
const nanobind::object &superCls)
600602
: pure_subclass(scope, valueClassName, superCls) {
601-
// Casting constructor. Note that it hard, if not impossible, to properly
603+
// Casting constructor. Note that it is hard, if not impossible, to properly
602604
// call chain to parent `__init__` in nanobind due to its special handling
603605
// for init functions that don't have a fully constructed self-reference,
604606
// which makes it impossible to forward it to `__init__` of a superclass.

0 commit comments

Comments
 (0)