Skip to content

Commit 59b7461

Browse files
[AsmParser] Avoid repeated hash lookups (NFC) (#109562)
1 parent 02cae55 commit 59b7461

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

mlir/lib/AsmParser/AsmParserState.cpp

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -289,9 +289,9 @@ void AsmParserState::finalizeRegionDefinition() {
289289
}
290290

291291
void AsmParserState::addDefinition(Block *block, SMLoc location) {
292-
auto it = impl->blocksToIdx.find(block);
293-
if (it == impl->blocksToIdx.end()) {
294-
impl->blocksToIdx.try_emplace(block, impl->blocks.size());
292+
auto [it, inserted] =
293+
impl->blocksToIdx.try_emplace(block, impl->blocks.size());
294+
if (inserted) {
295295
impl->blocks.emplace_back(std::make_unique<BlockDefinition>(
296296
block, convertIdLocToRange(location)));
297297
return;
@@ -379,11 +379,10 @@ void AsmParserState::addUses(Value value, ArrayRef<SMLoc> locations) {
379379
}
380380

381381
void AsmParserState::addUses(Block *block, ArrayRef<SMLoc> locations) {
382-
auto it = impl->blocksToIdx.find(block);
383-
if (it == impl->blocksToIdx.end()) {
384-
it = impl->blocksToIdx.try_emplace(block, impl->blocks.size()).first;
382+
auto [it, inserted] =
383+
impl->blocksToIdx.try_emplace(block, impl->blocks.size());
384+
if (inserted)
385385
impl->blocks.emplace_back(std::make_unique<BlockDefinition>(block));
386-
}
387386

388387
BlockDefinition &def = *impl->blocks[it->second];
389388
for (SMLoc loc : locations)

0 commit comments

Comments
 (0)