Addressed review comments.

Author: zahiraam

clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h

@@ -81,8 +81,8 @@ class ClangTidyContext {
 
   ~ClangTidyContext();
 
-  ClangTidyContext(const ClangTidyContext &) = default;
-  ClangTidyContext &operator=(const ClangTidyContext &) = default;
+  ClangTidyContext(const ClangTidyContext &) = delete;
+  ClangTidyContext &operator=(const ClangTidyContext &) = delete;
 
   /// Report any errors detected using this method.
   ///

clang-tools-extra/clang-tidy/NoLintDirectiveHandler.h

@@ -31,8 +31,8 @@ class NoLintDirectiveHandler {
 public:
   NoLintDirectiveHandler();
   ~NoLintDirectiveHandler();
-  NoLintDirectiveHandler(const NoLintDirectiveHandler &) = default;
-  NoLintDirectiveHandler &operator=(const NoLintDirectiveHandler &) = default;
+  NoLintDirectiveHandler(const NoLintDirectiveHandler &) = delete;
+  NoLintDirectiveHandler &operator=(const NoLintDirectiveHandler &) = delete;
 
   bool shouldSuppress(DiagnosticsEngine::Level DiagLevel,
                       const Diagnostic &Diag, llvm::StringRef DiagName,

clang-tools-extra/clangd/ClangdLSPServer.h

@@ -73,8 +73,8 @@ class ClangdLSPServer : private ClangdServer::Callbacks,
   /// The destructor blocks on any outstanding background tasks.
   ~ClangdLSPServer();
 
-  ClangdLSPServer(const ClangdLSPServer &other) = default;
-  ClangdLSPServer &operator=(const ClangdLSPServer &other) = default;
+  ClangdLSPServer(const ClangdLSPServer &other) = delete;
+  ClangdLSPServer &operator=(const ClangdLSPServer &other) = delete;
 
   /// Run LSP server loop, communicating with the Transport provided in the
   /// constructor. This method must not be executed more than once.

clang-tools-extra/clangd/ParsedAST.h

@@ -59,8 +59,8 @@ class ParsedAST {
 
   ~ParsedAST();
 
-  ParsedAST(const ParsedAST &Other) = default;
-  ParsedAST &operator=(const ParsedAST &Other) = default;
+  ParsedAST(const ParsedAST &Other) = delete;
+  ParsedAST &operator=(const ParsedAST &Other) = delete;
 
   /// Note that the returned ast will not contain decls from the preamble that
   /// were not deserialized during parsing. Clients should expect only decls

clang-tools-extra/clangd/TUScheduler.cpp

@@ -411,9 +411,9 @@ class PreambleThrottlerRequest {
     if (Throttler)
       Throttler->release(ID);
   }
-  PreambleThrottlerRequest(const PreambleThrottlerRequest &) = default;
+  PreambleThrottlerRequest(const PreambleThrottlerRequest &) = delete;
   PreambleThrottlerRequest &
-  operator=(const PreambleThrottlerRequest &) = default;
+  operator=(const PreambleThrottlerRequest &) = delete;
 
 private:
   PreambleThrottler::RequestID ID;
@@ -624,8 +624,8 @@ class ASTWorker {
          AsyncTaskRunner *Tasks, Semaphore &Barrier,
          const TUScheduler::Options &Opts, ParsingCallbacks &Callbacks);
   ~ASTWorker();
-  ASTWorker(const ASTWorker &other) = default;
-  ASTWorker &operator=(const ASTWorker &other) = default;
+  ASTWorker(const ASTWorker &other) = delete;
+  ASTWorker &operator=(const ASTWorker &other) = delete;
   void update(ParseInputs Inputs, WantDiagnostics, bool ContentChanged);
   void
   runWithAST(llvm::StringRef Name,

clang-tools-extra/clangd/TUScheduler.h

@@ -242,8 +242,8 @@ class TUScheduler {
               std::unique_ptr<ParsingCallbacks> ASTCallbacks = nullptr);
   ~TUScheduler();
 
-  TUScheduler(const TUScheduler &other) = default;
-  TUScheduler &operator=(const TUScheduler &other) = default;
+  TUScheduler(const TUScheduler &other) = delete;
+  TUScheduler &operator=(const TUScheduler &other) = delete;
 
   struct FileStats {
     std::size_t UsedBytesAST = 0;

clang-tools-extra/clangd/support/DirectiveTree.cpp

@@ -328,8 +328,8 @@ class Preprocessor {
   Preprocessor(const TokenStream &In, TokenStream &Out) : In(In), Out(Out) {}
   ~Preprocessor() { Out.finalize(); }
 
-  Preprocessor(const Preprocessor &other) = default;
-  Preprocessor &operator=(const Preprocessor &other) = default;
+  Preprocessor(const Preprocessor &other) = delete;
+  Preprocessor &operator=(const Preprocessor &other) = delete;
 
   void walk(const DirectiveTree &T) {
     for (const auto &C : T.Chunks)

clang-tools-extra/modularize/ModuleAssistant.cpp

@@ -46,8 +46,8 @@ class Module {
 public:
   Module(llvm::StringRef Name, bool Problem);
   ~Module();
-  Module(const Module &other) = default;
-  Module &operator=(const Module &other) = default;
+  Module(const Module &other) = delete;
+  Module &operator=(const Module &other) = delete;
   bool output(llvm::raw_fd_ostream &OS, int Indent);
   Module *findSubModule(llvm::StringRef SubName);