Skip to content

Commit 5a86a74

Browse files
committed
Address review comments
Created using spr 1.3.6-beta.1
1 parent c063c59 commit 5a86a74

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

llvm/lib/LTO/LTO.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -871,10 +871,10 @@ LTO::addRegularLTO(InputFile &Input, ArrayRef<SymbolResolution> InputRes,
871871
} else if (NamedMDNode *AliasesMD = M.getNamedMetadata("aliases")) {
872872
// Delete aliases entries for non-prevailing symbols on the ThinLTO side of
873873
// this input file.
874-
std::set<StringRef> Prevailing;
875-
for (auto P : zip(Input.symbols(), Res))
876-
if (std::get<1>(P).Prevailing && !std::get<0>(P).getIRName().empty())
877-
Prevailing.insert(std::get<0>(P).getIRName());
874+
DenseSet<StringRef> Prevailing;
875+
for (auto [I, R] : zip(Input.symbols(), Res))
876+
if (R.Prevailing && !I.getIRName().empty())
877+
Prevailing.insert(I.getIRName());
878878
std::vector<MDNode *> AliasGroups;
879879
for (MDNode *AliasGroup : AliasesMD->operands()) {
880880
std::vector<Metadata *> Aliases;

llvm/lib/Transforms/IPO/LowerTypeTests.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2245,7 +2245,7 @@ bool LowerTypeTestsModule::lower() {
22452245
if (ExportSummary) {
22462246
if (NamedMDNode *AliasesMD = M.getNamedMetadata("aliases")) {
22472247
for (auto *AliasMD : AliasesMD->operands()) {
2248-
std::vector<Function *> Aliases;
2248+
SmallVector<Function *> Aliases;
22492249
for (Metadata *MD : AliasMD->operands()) {
22502250
auto *MDS = dyn_cast<MDString>(MD);
22512251
if (!MDS)

llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -444,7 +444,7 @@ void splitAndWriteThinLTOBitcode(
444444
if (!FunctionAliases.empty()) {
445445
NamedMDNode *NMD = MergedM->getOrInsertNamedMetadata("aliases");
446446
for (auto &Alias : FunctionAliases) {
447-
std::vector<Metadata *> Elts;
447+
SmallVector<Metadata *> Elts;
448448
Elts.push_back(MDString::get(Ctx, Alias.first->getName()));
449449
for (auto *A : Alias.second)
450450
Elts.push_back(MDString::get(Ctx, A->getName()));

0 commit comments

Comments
 (0)