Address reviews

Author: gysit

mlir/lib/Target/LLVMIR/ModuleTranslation.cpp

@@ -1764,8 +1764,8 @@ LogicalResult ModuleTranslation::convertArgAndResultAttrs(
   // Convert the argument attributes.
   if (ArrayAttr argAttrsArray = attrsOp.getArgAttrsAttr()) {
     unsigned argAttrIdx = 0;
-    llvm::DenseSet<unsigned> immArgPositionsSet(immArgPositions.begin(),
-                                                immArgPositions.end());
+    llvm::SmallDenseSet<unsigned> immArgPositionsSet(immArgPositions.begin(),
+                                                     immArgPositions.end());
     for (unsigned argIdx : llvm::seq<unsigned>(call->arg_size())) {
       if (argAttrIdx >= argAttrsArray.size())
         break;

mlir/test/Target/LLVMIR/llvmir-intrinsics.mlir

@@ -607,6 +607,10 @@ llvm.func @memcpy_test(%arg0: i32, %arg2: !llvm.ptr, %arg3: !llvm.ptr) {
   "llvm.intr.memcpy.inline"(%arg2, %arg3) <{arg_attrs = [{llvm.align = 4 : i64}, {}], isVolatile = true, len = 10 : i32}> : (!llvm.ptr, !llvm.ptr) -> ()
   // CHECK: call void @llvm.memcpy.inline.p0.p0.i64(ptr %{{.*}}, ptr %{{.*}}, i64 10, i1 true
   "llvm.intr.memcpy.inline"(%arg2, %arg3) <{isVolatile = true, len = 10 : i64}> : (!llvm.ptr, !llvm.ptr) -> ()
+
+  // Verify that trailing empty argument attribute dictionaries can be omitted.
+  // CHECK: call void @llvm.memcpy.p0.p0.i32(ptr align 4 %{{.*}}, ptr align 8 %{{.*}}, i32 %{{.*}}, i1 false
+  "llvm.intr.memcpy"(%arg2, %arg3, %arg0) <{arg_attrs = [{llvm.align = 4 : i64}, {llvm.align = 8 : i64}], isVolatile = false}> : (!llvm.ptr, !llvm.ptr, i32) -> ()
   llvm.return
 }