Skip to content

Commit 5bce6f8

Browse files
committed
address comments
1 parent ab53366 commit 5bce6f8

File tree

1 file changed

+6
-9
lines changed

1 file changed

+6
-9
lines changed

llvm/lib/Transforms/AggressiveInstCombine/AggressiveInstCombine.cpp

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1458,8 +1458,7 @@ static bool foldLibCalls(Instruction &I, TargetTransformInfo &TTI,
14581458
}
14591459

14601460
/// Match low part of 128-bit multiplication.
1461-
static bool foldMul128Low(Instruction &I, const DataLayout &DL,
1462-
DominatorTree &DT) {
1461+
static bool foldMul128Low(Instruction &I) {
14631462
auto *Ty = I.getType();
14641463
if (!Ty->isIntegerTy(64))
14651464
return false;
@@ -1530,8 +1529,7 @@ static bool foldMul128Low(Instruction &I, const DataLayout &DL,
15301529
}
15311530

15321531
/// Match high part of 128-bit multiplication.
1533-
static bool foldMul128High(Instruction &I, const DataLayout &DL,
1534-
DominatorTree &DT) {
1532+
static bool foldMul128High(Instruction &I) {
15351533
auto *Ty = I.getType();
15361534
if (!Ty->isIntegerTy(64))
15371535
return false;
@@ -1649,8 +1647,7 @@ static bool foldMul128High(Instruction &I, const DataLayout &DL,
16491647
/// %u1_hi = lshr i64 %u1, 32
16501648
/// %u2 = add nuw i64 %u0_hi, %t3
16511649
/// %hw64 = add nuw i64 %u2, %u1_hi
1652-
static bool foldMul128HighVariant(Instruction &I, const DataLayout &DL,
1653-
DominatorTree &DT) {
1650+
static bool foldMul128HighVariant(Instruction &I) {
16541651
auto *Ty = I.getType();
16551652
if (!Ty->isIntegerTy(64))
16561653
return false;
@@ -1739,9 +1736,9 @@ static bool foldUnusualPatterns(Function &F, DominatorTree &DT,
17391736
MadeChange |= foldConsecutiveLoads(I, DL, TTI, AA, DT);
17401737
MadeChange |= foldPatternedLoads(I, DL);
17411738
MadeChange |= foldICmpOrChain(I, DL, TTI, AA, DT);
1742-
MadeChange |= foldMul128Low(I, DL, DT);
1743-
MadeChange |= foldMul128High(I, DL, DT);
1744-
MadeChange |= foldMul128HighVariant(I, DL, DT);
1739+
MadeChange |= foldMul128Low(I);
1740+
MadeChange |= foldMul128High(I);
1741+
MadeChange |= foldMul128HighVariant(I);
17451742
// NOTE: This function introduces erasing of the instruction `I`, so it
17461743
// needs to be called at the end of this sequence, otherwise we may make
17471744
// bugs.

0 commit comments

Comments
 (0)