Skip to content

Commit 5bddd42

Browse files
committed
CR 3 and removed update of a test, cause moved to another PR
1 parent 5b80374 commit 5bddd42

File tree

2 files changed

+11
-13
lines changed

2 files changed

+11
-13
lines changed

mlir/lib/Dialect/SCF/IR/SCF.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -334,7 +334,7 @@ struct ExecuteRegionForwardingEliminator
334334
opResultsToReplaceWithExternalValues.push_back(op.getResult(index));
335335
}
336336
}
337-
// No yeilded external values - nothing to do.
337+
// No yielded external values - nothing to do.
338338
if (externalValues.empty())
339339
return failure();
340340

mlir/test/Dialect/Bufferization/Transforms/one-shot-module-bufferize.mlir

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -377,23 +377,21 @@ func.func private @execute_region_test(%t1 : tensor<?xf32>)
377377
// CHECK: return %{{.*}}, %{{.*}} : f32, f32
378378
return %0, %1, %2 : f32, tensor<?xf32>, f32
379379
}
380+
380381
// -----
381382

382383
// CHECK-LABEL: func @no_inline_execute_region_not_canonicalized
383-
module {
384-
func.func private @foo()->()
385-
func.func @no_inline_execute_region_not_canonicalized() {
386-
%c = arith.constant 42 : i32
387-
// CHECK: scf.execute_region
388-
// CHECK-SAME: no_inline
389-
%v = scf.execute_region -> i32 no_inline {
390-
func.call @foo():()->()
391-
scf.yield %c : i32
392-
}
393-
// CHECK: return
394-
return
384+
func.func @no_inline_execute_region_not_canonicalized() {
385+
%c = arith.constant 42 : i32
386+
// CHECK: scf.execute_region
387+
// CHECK-SAME: no_inline
388+
%v = scf.execute_region -> i32 no_inline {
389+
scf.yield %c : i32
395390
}
391+
// CHECK: return
392+
return
396393
}
394+
397395
// -----
398396

399397
// CHECK: func private @some_external_func(memref<?xf32, strided<[?], offset: ?>>)

0 commit comments

Comments
 (0)