Skip to content

Commit 5c53494

Browse files
committed
R3: Addressing review comments
1 parent 72a9c3a commit 5c53494

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

flang/include/flang/Optimizer/Dialect/Support/FIRContext.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ bool getAtomicRemoteMemory(mlir::ModuleOp mod);
7575
/// module `mod` is still live.
7676
void setTuneCPU(mlir::ModuleOp mod, llvm::StringRef cpu);
7777

78-
// set Atomic control options for amd gpu.
78+
// set atomic control options for AMD gpu.
7979
void setAmdgpuAtomicControlOptions(mlir::ModuleOp mod,
8080
bool amdgpuIgnoreDenormalMode,
8181
bool amdgpuNoFineGrainedMemory,

mlir/include/mlir/Dialect/OpenMP/OpenMPAttrDefs.td

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,8 @@ def FlagsAttr : OpenMP_Attr<"Flags", "flags"> {
7373
// AtomicControlAttr
7474
//===----------------------------------------------------------------------===//
7575

76-
// Runtime library flags attribute that holds information for lowering to LLVM.
76+
// Atomic control attributes hold information about architectural
77+
// characteristics which are required for lowering atomic operations.
7778
def AtomicControlAttr : OpenMP_Attr<"AtomicControl", "atomic_control"> {
7879
let parameters =
7980
(ins DefaultValuedParameter<"bool", "false">:$amdgpu_ignore_denormal_mode,

0 commit comments

Comments
 (0)