Address review comments

Author: tbaederr

clang/lib/AST/Interp/InterpBitcast.cpp

@@ -17,8 +17,6 @@
 namespace clang {
 namespace interp {
 
-// TODO: Try to e-duplicate the primitive and composite versions.
-
 /// Used to iterate over pointer fields.
 using DataFunc =
     llvm::function_ref<bool(const Pointer &P, PrimType Ty, size_t BitOffset)>;
@@ -383,7 +381,6 @@ bool DoBitCastToPtr(InterpState &S, const Pointer &P, Pointer &DestPtr,
         if (T == PT_Float) {
           const QualType FloatType = P.getFieldDesc()->getType();
           const auto &Sem = ASTCtx.getFloatTypeSemantics(FloatType);
-          size_t ValueReprBits = ASTCtx.getTypeSize(FloatType);
 
           CharUnits ObjectReprChars = ASTCtx.getTypeSizeInChars(P.getType());
           const std::byte *M = Bytes.getBytes(BitOffset, 1234);

clang/test/AST/Interp/builtin-bit-cast.cpp

@@ -49,6 +49,19 @@ static_assert(FromString == 1633837824); // ref-error {{is not an integral const
                                          // ref-note {{initializer of 'FromString' is not a constant expression}}
 #endif
 
+
+struct S {
+  int i, j, k;
+};
+constexpr S func() {
+  constexpr int array[] = { 12, 42, 128 };
+  return __builtin_bit_cast(S, array);
+}
+constexpr S s = func();
+static_assert(s.i == 12, "");
+static_assert(s.j == 42, "");
+static_assert(s.k == 128, "");
+
 template <class Intermediate, class Init>
 constexpr bool round_trip(const Init &init) {
   return bit_cast<Init>(bit_cast<Intermediate>(init)) == init;