review comment resolved

removed change in MachineVerifier

Author: AbhayKanhere

llvm/lib/CodeGen/MachineVerifier.cpp

@@ -2589,7 +2589,7 @@ MachineVerifier::visitMachineOperand(const MachineOperand *MO, unsigned MONum) {
     if (!MO->isReg())
       report("Early clobber must be a register", MO, MONum);
     if (!MO->isEarlyClobber())
-      report("Missing earlyClobber flag", MO, MONum);
+      report("Missing earlyClobber flag", MI);
   }
 
   switch (MO->getType()) {

llvm/lib/Target/AMDGPU/SIFoldOperands.cpp

@@ -681,6 +681,10 @@ bool SIFoldOperandsImpl::updateOperand(FoldCandidate &Fold) const {
         return false;
       MI->setDesc(TII->get(NewMFMAOpc));
       MI->untieRegOperand(0);
+      const MCInstrDesc &MCID = MI->getDesc();
+      for (unsigned I = 0; I < MI->getNumDefs(); ++I)
+        if (MCID.getOperandConstraint(I, MCOI::EARLY_CLOBBER) != -1)
+          MI->getOperand(I).setIsEarlyClobber(true);
     }
 
     // TODO: Should we try to avoid adding this to the candidate list?
@@ -689,10 +693,6 @@ bool SIFoldOperandsImpl::updateOperand(FoldCandidate &Fold) const {
     if (!TII->isOperandLegal(*MI, OpNo, &New))
       return false;
 
-    const MCInstrDesc &MCID = MI->getDesc();
-    for (unsigned I = 0; I < MI->getNumDefs(); ++I)
-      if (MCID.getOperandConstraint(I, MCOI::EARLY_CLOBBER) != -1)
-        MI->getOperand(I).setIsEarlyClobber(true);
     Old.ChangeToImmediate(*ImmVal);
     return true;
   }