resolve comments

Author: mingmingl-llvm

llvm/include/llvm/ProfileData/DataAccessProf.h

@@ -112,7 +112,7 @@ struct DataAccessProfRecord {
       SymHandle = std::get<uint64_t>(SymHandleRef);
 
     for (auto Loc : LocRefs)
-      Locations.emplace_back(SourceLocation(Loc.FileName, Loc.Line));
+      Locations.emplace_back(Loc.FileName, Loc.Line);
   }
   // Empty constructor is used in yaml conversion.
   DataAccessProfRecord() {}

llvm/include/llvm/ProfileData/IndexedMemProfData.h

@@ -89,8 +89,7 @@ struct IndexedMemProfData {
 Error writeMemProf(
     ProfOStream &OS, memprof::IndexedMemProfData &MemProfData,
     memprof::IndexedVersion MemProfVersionRequested, bool MemProfFullSchema,
-    std::unique_ptr<memprof::DataAccessProfData>
-        DataAccessProfileData);
+    std::unique_ptr<memprof::DataAccessProfData> DataAccessProfileData);
 
 } // namespace llvm
 #endif

llvm/lib/ProfileData/IndexedMemProfData.cpp

@@ -219,7 +219,8 @@ static Error writeMemProfV2(ProfOStream &OS,
 static Error writeMemProfRadixTreeBased(
     ProfOStream &OS, memprof::IndexedMemProfData &MemProfData,
     memprof::IndexedVersion Version, bool MemProfFullSchema,
-    std::unique_ptr<memprof::DataAccessProfData> DataAccessProfileData) {
+    std::unique_ptr<memprof::DataAccessProfData> DataAccessProfileData =
+        nullptr) {
   assert((Version == memprof::Version3 || Version == memprof::Version4) &&
          "Unsupported version for radix tree format");
 
@@ -289,7 +290,7 @@ static Error writeMemProfV3(ProfOStream &OS,
                             memprof::IndexedMemProfData &MemProfData,
                             bool MemProfFullSchema) {
   return writeMemProfRadixTreeBased(OS, MemProfData, memprof::Version3,
-                                    MemProfFullSchema, nullptr);
+                                    MemProfFullSchema);
 }
 
 // Write out MemProf Version4

llvm/lib/ProfileData/InstrProfWriter.cpp

@@ -29,7 +29,6 @@
 #include "llvm/Support/raw_ostream.h"
 #include <cstdint>
 #include <ctime>
-#include <functional>
 #include <memory>
 #include <string>
 #include <tuple>