Skip to content

Commit 5d7aade

Browse files
committed
Add TODO
1 parent 39650a3 commit 5d7aade

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

mlir/lib/Dialect/SCF/Transforms/TileUsingInterface.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -656,6 +656,9 @@ getResultTilePosition(RewriterBase &rewriter, int64_t index, Value tiledResult,
656656
resultOffset, resultSize);
657657
case scf::SCFTilingOptions::ReductionTilingStrategy::
658658
PartialReductionOuterReduction: {
659+
// TODO: This does not work for non identity accesses to the result tile.
660+
// The proper fix is to add a getPartialResultTilePosition method to
661+
// PartialReductionOpInterface.
659662
resultOffset =
660663
SmallVector<OpFoldResult>(offsets.size(), rewriter.getIndexAttr(0));
661664
for (size_t i = 0; i < offsets.size(); i++) {

0 commit comments

Comments
 (0)