No need of explicit Twine constructor

jurahul · jurahul · commit 5e067b2197f0 · 2025-10-17T08:37:56.000-07:00
diff --git a/mlir/tools/mlir-tblgen/OpInterfacesGen.cpp b/mlir/tools/mlir-tblgen/OpInterfacesGen.cpp
@@ -442,8 +442,7 @@ void InterfaceGenerator::emitModelMethodsDef(const Interface &interface) {
 }
 
 void InterfaceGenerator::emitInterfaceTraitDecl(const Interface &interface) {
-  llvm::NamespaceEmitter ns(os,
-                            Twine(interface.getCppNamespace()) + "::detail");
+  llvm::NamespaceEmitter ns(os, interface.getCppNamespace() + "::detail");
 
   StringRef interfaceName = interface.getName();
   auto interfaceTraitsName = (interfaceName + "InterfaceTraits").str();

Original file line number	Diff line number	Diff line change
`@@ -442,8 +442,7 @@ void InterfaceGenerator::emitModelMethodsDef(const Interface &interface) {`
`442`	`442`	`}`
`443`	`443`
`444`	`444`	`void InterfaceGenerator::emitInterfaceTraitDecl(const Interface &interface) {`
`445`		`- llvm::NamespaceEmitter ns(os,`
`446`		`- Twine(interface.getCppNamespace()) + "::detail");`
	`445`	`+ llvm::NamespaceEmitter ns(os, interface.getCppNamespace() + "::detail");`
`447`	`446`
`448`	`447`	`StringRef interfaceName = interface.getName();`
`449`	`448`	`auto interfaceTraitsName = (interfaceName + "InterfaceTraits").str();`