[llvm-objcopy] Let --change-section-lma change segments wth filesz=0, memsz>0

Currently, segments with a file size of 0 are ignored for the purposes of
--change-section-lma, regardless of their memory size. It seems reasonable
to me to modify such segments given that we're changing the LMA for all
sections and these LMAs may be used during loading. GNU objcopy also seems
to adjust such segments.

Fixes #124680

Author: jonathonpenix

llvm/lib/ObjCopy/ELF/ELFObjcopy.cpp

@@ -824,7 +824,7 @@ static Error handleArgs(const CommonConfig &Config, const ELFConfig &ELFConfig,
 
   if (Config.ChangeSectionLMAValAll != 0) {
     for (Segment &Seg : Obj.segments()) {
-      if (Seg.FileSize > 0) {
+      if (Seg.FileSize > 0 || Seg.MemSize > 0) {
         if (Config.ChangeSectionLMAValAll > 0 &&
             Seg.PAddr > std::numeric_limits<uint64_t>::max() -
                             Config.ChangeSectionLMAValAll) {

llvm/test/tools/llvm-objcopy/ELF/change-section-lma.test

@@ -14,16 +14,18 @@
 
 # CHECK-PLUS-PROGRAMS:  Type           Offset   VirtAddr           PhysAddr           FileSiz  MemSiz
 # CHECK-PLUS-PROGRAMS:  PHDR           0x000002 0x0000000000001102 0x0000000000001122 0x000038 0x000000
-# CHECK-PLUS-PROGRAMS:  LOAD           0x000000 0x0000000000001100 0x0000000000001120 0x000258 0x000258
-# CHECK-PLUS-PROGRAMS:  LOAD           0x000258 0xffffffff00005100 0xffffffff00006120 0x000100 0x000100
+# CHECK-PLUS-PROGRAMS:  LOAD           0x000000 0x0000000000001100 0x0000000000001120 0x000290 0x000290
+# CHECK-PLUS-PROGRAMS:  LOAD           0x000290 0xffffffff00005100 0xffffffff00006120 0x000100 0x000100
 # CHECK-PLUS-PROGRAMS:  NOTE           0x000358 0x0000000000001200 0x0000000000001220 0x000010 0x000000
 # CHECK-PLUS-PROGRAMS:  NOTE           0x000368 0x0000000000000000 0x0000000000000000 0x000000 0x000000
+# CHECK-PLUS-PROGRAMS:  LOAD           0x000390 0x0000000000001300 0x0000000000001320 0x000000 0x000010
 
 # CHECK-MINUS-PROGRAMS:  PHDR           0x000002 0x0000000000001102 0x00000000000010d2 0x000038 0x000000
-# CHECK-MINUS-PROGRAMS:  LOAD           0x000000 0x0000000000001100 0x00000000000010d0 0x000258 0x000258
-# CHECK-MINUS-PROGRAMS:  LOAD           0x000258 0xffffffff00005100 0xffffffff000060d0 0x000100 0x000100
+# CHECK-MINUS-PROGRAMS:  LOAD           0x000000 0x0000000000001100 0x00000000000010d0 0x000290 0x000290
+# CHECK-MINUS-PROGRAMS:  LOAD           0x000290 0xffffffff00005100 0xffffffff000060d0 0x000100 0x000100
 # CHECK-MINUS-PROGRAMS:  NOTE           0x000358 0x0000000000001200 0x00000000000011d0 0x000010 0x000000
 # CHECK-MINUS-PROGRAMS:  NOTE           0x000368 0x0000000000000000 0x0000000000000000 0x000000 0x000000
+# CHECK-MINUS-PROGRAMS:  LOAD           0x000390 0x0000000000001300 0x00000000000012d0 0x000000 0x000010
 
 # CHECK-PLUS-SECTIONS:      [Nr] Name              Type            Address          Off    Size   ES Flg Lk Inf Al
 # CHECK-PLUS-SECTIONS:           .text1
@@ -55,6 +57,9 @@ Sections:
   - Name:          .text2
     Type:          SHT_PROGBITS
     Size:          0x100
+  - Name:          .bss1
+    Type:          SHT_NOBITS
+    Size:          0x10
 ProgramHeaders:
   - Type:          PT_PHDR
     FileSize:      0x38
@@ -77,3 +82,7 @@ ProgramHeaders:
   - Type:          PT_NOTE
     FileSize:      0x0
     Offset:        0x368
+  - Type:          PT_LOAD
+    VAddr:         0x1300
+    FirstSec:      .bss1
+    LastSec:       .bss1