Skip to content

Commit 5f40731

Browse files
committed
Rename llvmPrivateVars to llvmPrivateVarGEPs
1 parent b18b1fa commit 5f40731

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1793,8 +1793,8 @@ class TaskContextStructManager {
17931793
/// De-allocate the task context structure.
17941794
void freeStructPtr();
17951795

1796-
MutableArrayRef<llvm::Value *> getLLVMPrivateVars() {
1797-
return llvmPrivateVars;
1796+
MutableArrayRef<llvm::Value *> getLLVMPrivateVarGEPs() {
1797+
return llvmPrivateVarGEPs;
17981798
}
17991799

18001800
llvm::Value *getStructPtr() { return structPtr; }
@@ -1809,7 +1809,7 @@ class TaskContextStructManager {
18091809

18101810
/// LLVM values for each private variable, or null if that private variable is
18111811
/// not included in the task context structure
1812-
SmallVector<llvm::Value *> llvmPrivateVars;
1812+
SmallVector<llvm::Value *> llvmPrivateVarGEPs;
18131813

18141814
/// A pointer to the structure containing context for this task.
18151815
llvm::Value *structPtr = nullptr;
@@ -1853,19 +1853,19 @@ void TaskContextStructManager::createGEPsToPrivateVars() {
18531853
}
18541854

18551855
// Create GEPs for each struct member
1856-
llvmPrivateVars.clear();
1857-
llvmPrivateVars.reserve(privateDecls.size());
1856+
llvmPrivateVarGEPs.clear();
1857+
llvmPrivateVarGEPs.reserve(privateDecls.size());
18581858
llvm::Value *zero = builder.getInt32(0);
18591859
unsigned i = 0;
18601860
for (auto privDecl : privateDecls) {
18611861
if (!privDecl.readsFromMold()) {
18621862
// Handle this inside of the task so we don't pass unnessecary vars in
1863-
llvmPrivateVars.push_back(nullptr);
1863+
llvmPrivateVarGEPs.push_back(nullptr);
18641864
continue;
18651865
}
18661866
llvm::Value *iVal = builder.getInt32(i);
18671867
llvm::Value *gep = builder.CreateGEP(structTy, structPtr, {zero, iVal});
1868-
llvmPrivateVars.push_back(gep);
1868+
llvmPrivateVarGEPs.push_back(gep);
18691869
i += 1;
18701870
}
18711871
}
@@ -1960,7 +1960,7 @@ convertOmpTaskOp(omp::TaskOp taskOp, llvm::IRBuilderBase &builder,
19601960

19611961
for (auto [privDecl, mlirPrivVar, blockArg, llvmPrivateVarAlloc] :
19621962
llvm::zip_equal(privateDecls, mlirPrivateVars, privateBlockArgs,
1963-
taskStructMgr.getLLVMPrivateVars())) {
1963+
taskStructMgr.getLLVMPrivateVarGEPs())) {
19641964
if (!privDecl.readsFromMold())
19651965
// to be handled inside the task
19661966
continue;
@@ -1999,7 +1999,7 @@ convertOmpTaskOp(omp::TaskOp taskOp, llvm::IRBuilderBase &builder,
19991999
// firstprivate copy region
20002000
setInsertPointForPossiblyEmptyBlock(builder, copyBlock);
20012001
if (failed(copyFirstPrivateVars(builder, moduleTranslation, mlirPrivateVars,
2002-
taskStructMgr.getLLVMPrivateVars(),
2002+
taskStructMgr.getLLVMPrivateVarGEPs(),
20032003
privateDecls)))
20042004
return llvm::failure();
20052005

@@ -2042,7 +2042,7 @@ convertOmpTaskOp(omp::TaskOp taskOp, llvm::IRBuilderBase &builder,
20422042
// Find and map the addresses of each variable within the task context
20432043
// structure
20442044
taskStructMgr.createGEPsToPrivateVars();
2045-
llvm::copy(taskStructMgr.getLLVMPrivateVars(),
2045+
llvm::copy(taskStructMgr.getLLVMPrivateVarGEPs(),
20462046
std::back_inserter(llvmPrivateVars));
20472047
for (auto [blockArg, llvmPrivateVar] :
20482048
llvm::zip_equal(privateBlockArgs, llvmPrivateVars)) {

0 commit comments

Comments
 (0)