Skip to content

Commit 5facc37

Browse files
committed
fixup: update comments
1 parent 1d9a104 commit 5facc37

File tree

2 files changed

+1
-8
lines changed

2 files changed

+1
-8
lines changed

mlir/lib/Pass/PassCrashRecovery.cpp

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -411,12 +411,6 @@ struct FileReproducerStream : public mlir::ReproducerStream {
411411

412412
LogicalResult PassManager::runWithCrashRecovery(Operation *op,
413413
AnalysisManager am) {
414-
// Notify the context to disable the use of thread-local storage for
415-
// allocating attribute storage while the pass manager is running in a crash
416-
// recovery context thread. Re-enable the thread-local storage upon function
417-
// exit. This is required to persist any attribute storage allocated in
418-
// thread-local storage during passes beyond the lifetime of the recovery
419-
// context thread.
420414
const bool threadingEnabled = getContext()->isMultithreadingEnabled();
421415
crashReproGenerator->initialize(getPasses(), op, verifyPasses);
422416

mlir/unittests/IR/DistinctAttributeAllocatorTest.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,7 @@ using namespace mlir;
1919

2020
//
2121
// Test that a DistinctAttr that is created on a separate thread does
22-
// not have its storage deleted when thread local storage is disabled
23-
// on the MLIRContext.
22+
// not have its storage deleted when the thread joins
2423
//
2524
TEST(DistinctAttributeAllocatorTest, TestAttributeWellFormedAfterThreadJoin) {
2625
MLIRContext ctx;

0 commit comments

Comments
 (0)