Skip to content

Commit 6007895

Browse files
committed
Remove modifications to Lint/Verifier.
1 parent 3f5634a commit 6007895

File tree

2 files changed

+5
-19
lines changed

2 files changed

+5
-19
lines changed

llvm/lib/Analysis/Lint.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -735,11 +735,9 @@ PreservedAnalyses LintPass::run(Function &F, FunctionAnalysisManager &AM) {
735735
Lint L(Mod, DL, AA, AC, DT, TLI);
736736
L.visit(F);
737737
dbgs() << L.MessagesStr.str();
738-
if (AbortOnError && !L.MessagesStr.str().empty()) {
738+
if (AbortOnError && !L.MessagesStr.str().empty())
739739
report_fatal_error(
740740
"linter found errors, aborting. (enabled by abort-on-error)", false);
741-
return PreservedAnalyses::none();
742-
}
743741
return PreservedAnalyses::all();
744742
}
745743

llvm/lib/IR/Verifier.cpp

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -135,10 +135,6 @@ static cl::opt<bool> VerifyNoAliasScopeDomination(
135135
cl::desc("Ensure that llvm.experimental.noalias.scope.decl for identical "
136136
"scopes are not dominating"));
137137

138-
static cl::opt<bool>
139-
VerifyAbortOnError("verifier-abort-on-error", cl::init(false),
140-
cl::desc("In the Verifier pass, abort on errors."));
141-
142138
namespace llvm {
143139

144140
struct VerifierSupport {
@@ -7869,24 +7865,16 @@ VerifierAnalysis::Result VerifierAnalysis::run(Function &F,
78697865

78707866
PreservedAnalyses VerifierPass::run(Module &M, ModuleAnalysisManager &AM) {
78717867
auto Res = AM.getResult<VerifierAnalysis>(M);
7872-
if (Res.IRBroken || Res.DebugInfoBroken) {
7873-
//M.IsValid = false;
7874-
if (VerifyAbortOnError && FatalErrors)
7875-
report_fatal_error("Broken module found, compilation aborted!");
7876-
return PreservedAnalyses::none();
7877-
}
7868+
if (FatalErrors && (Res.IRBroken || Res.DebugInfoBroken))
7869+
report_fatal_error("Broken module found, compilation aborted!");
78787870

78797871
return PreservedAnalyses::all();
78807872
}
78817873

78827874
PreservedAnalyses VerifierPass::run(Function &F, FunctionAnalysisManager &AM) {
78837875
auto res = AM.getResult<VerifierAnalysis>(F);
7884-
if (res.IRBroken) {
7885-
//F.getParent()->IsValid = false;
7886-
if (VerifyAbortOnError && FatalErrors)
7887-
report_fatal_error("Broken function found, compilation aborted!");
7888-
return PreservedAnalyses::none();
7889-
}
7876+
if (res.IRBroken && FatalErrors)
7877+
report_fatal_error("Broken function found, compilation aborted!");
78907878

78917879
return PreservedAnalyses::all();
78927880
}

0 commit comments

Comments
 (0)