Skip to content

Commit 6046c68

Browse files
committed
Apply reviewer comments to performFNegCombine
1 parent 235d6a5 commit 6046c68

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5286,15 +5286,13 @@ SDValue AMDGPUTargetLowering::performFNegCombine(SDNode *N,
52865286
SDValue Cond = N0.getOperand(0);
52875287
SDValue LHS = N0.getOperand(1);
52885288
SDValue RHS = N0.getOperand(2);
5289-
EVT LHVT = LHS.getValueType();
5290-
EVT RHVT = RHS.getValueType();
5291-
// The regression was limited to i32 v2/i32.
5292-
if (RHVT != MVT::i32 && LHVT != MVT::i32)
5289+
EVT VT = LHS.getValueType();
5290+
if (VT != MVT::i32)
52935291
return SDValue();
52945292

5295-
SDValue LFNeg = DAG.getNode(ISD::FNEG, SL, LHVT, LHS);
5296-
SDValue RFNeg = DAG.getNode(ISD::FNEG, SL, RHVT, RHS);
5297-
SDValue Op = DAG.getNode(Opc, SL, LHVT, Cond, LFNeg, RFNeg);
5293+
SDValue LFNeg = DAG.getNode(ISD::FNEG, SL, VT, LHS);
5294+
SDValue RFNeg = DAG.getNode(ISD::FNEG, SL, VT, RHS);
5295+
SDValue Op = DAG.getNode(Opc, SL, VT, Cond, LFNeg, RFNeg);
52985296
return Op;
52995297
}
53005298
case ISD::BITCAST: {

0 commit comments

Comments
 (0)