[clang-tidy] Few tiny fixes after #99084

Summary: Update documentation, and correct configuration

Test Plan: 

Reviewers: 

Subscribers: 

Tasks: 

Tags: 


Differential Revision: https://phabricator.intern.facebook.com/D60251646

Author: PiotrZSL

clang-tools-extra/clang-tidy/bugprone/UnusedReturnValueCheck.cpp

@@ -138,13 +138,13 @@ UnusedReturnValueCheck::UnusedReturnValueCheck(llvm::StringRef Name,
                                           "^::sigismember$;"
                                           "^::strcasecmp$;"
                                           "^::strsignal$;"
-                                          "^::ttyname"))),
+                                          "^::ttyname$"))),
       CheckedReturnTypes(utils::options::parseStringList(
-          Options.get("CheckedReturnTypes", "::std::error_code$;"
-                                            "::std::error_condition$;"
-                                            "::std::errc$;"
-                                            "::std::expected$;"
-                                            "::boost::system::error_code"))),
+          Options.get("CheckedReturnTypes", "^::std::error_code$;"
+                                            "^::std::error_condition$;"
+                                            "^::std::errc$;"
+                                            "^::std::expected$;"
+                                            "^::boost::system::error_code$"))),
       AllowCastToVoid(Options.get("AllowCastToVoid", false)) {}
 
 UnusedReturnValueCheck::UnusedReturnValueCheck(

clang-tools-extra/docs/clang-tidy/checks/bugprone/unused-return-value.rst

@@ -16,23 +16,26 @@ Options
    This parameter supports regexp. The function is checked if the name
    and scope matches, with any arguments.
    By default the following functions are checked:
-   ``::std::async$, ::std::launder$, ::std::remove$, ::std::remove_if$, ::std::unique$,
-   ::std::unique_ptr::release$, ::std::basic_string::empty$, ::std::vector::empty$,
-   ::std::back_inserter$, ::std::distance$, ::std::find$, ::std::find_if$, ::std::inserter$,
-   ::std::lower_bound$, ::std::make_pair$, ::std::map::count$, ::std::map::find$,
-   ::std::map::lower_bound$, ::std::multimap::equal_range$, ::std::multimap::upper_bound$,
-   ::std::set::count$, ::std::set::find$, ::std::setfill$, ::std::setprecision$,
-   ::std::setw$, ::std::upper_bound$, ::std::vector::at$, ::bsearch$, ::ferror$,
-   ::feof$, ::isalnum$, ::isalpha$, ::isblank$, ::iscntrl$, ::isdigit$, ::isgraph$,
-   ::islower$, ::isprint$, ::ispunct$, ::isspace$, ::isupper$, ::iswalnum$, ::iswprint$,
-   ::iswspace$, ::isxdigit$, ::memchr$, ::memcmp$, ::strcmp$, ::strcoll$, ::strncmp$,
-   ::strpbrk$, ::strrchr$, ::strspn$, ::strstr$, ::wcscmp$, ::access$, ::bind$,
-   ::connect$, ::difftime$, ::dlsym$, ::fnmatch$, ::getaddrinfo$, ::getopt$,
-   ::htonl$, ::htons$, ::iconv_open$, ::inet_addr$, isascii$, isatty$, ::mmap$,
-   ::newlocale$, ::openat$, ::pathconf$, ::pthread_equal$, ::pthread_getspecific$,
-   ::pthread_mutex_trylock$, ::readdir$, ::readlink$, ::recvmsg$, ::regexec$, ::scandir$,
-   ::semget$, ::setjmp$, ::shm_open$, ::shmget$, ::sigismember$, ::strcasecmp$, ::strsignal$,
-   ::ttyname$``
+   ``^::std::async$, ^::std::launder$, ^::std::remove$, ^::std::remove_if$,
+   ^::std::unique$, ^::std::unique_ptr::release$, ^::std::basic_string::empty$,
+   ^::std::vector::empty$, ^::std::back_inserter$, ^::std::distance$,
+   ^::std::find$, ^::std::find_if$, ^::std::inserter$, ^::std::lower_bound$,
+   ^::std::make_pair$, ^::std::map::count$, ^::std::map::find$,
+   ^::std::map::lower_bound$, ^::std::multimap::equal_range$,
+   ^::std::multimap::upper_bound$, ^::std::set::count$, ^::std::set::find$,
+   ^::std::setfill$, ^::std::setprecision$, ^::std::setw$, ^::std::upper_bound$,
+   ^::std::vector::at$, ^::bsearch$, ^::ferror$, ^::feof$, ^::isalnum$,
+   ^::isalpha$, ^::isblank$, ^::iscntrl$, ^::isdigit$, ^::isgraph$, ^::islower$,
+   ^::isprint$, ^::ispunct$, ^::isspace$, ^::isupper$, ^::iswalnum$,
+   ^::iswprint$, ^::iswspace$, ^::isxdigit$, ^::memchr$, ^::memcmp$, ^::strcmp$,
+   ^::strcoll$, ^::strncmp$, ^::strpbrk$, ^::strrchr$, ^::strspn$, ^::strstr$,
+   ^::wcscmp$, ^::access$, ^::bind$, ^::connect$, ^::difftime$, ^::dlsym$,
+   ^::fnmatch$, ^::getaddrinfo$, ^::getopt$, ^::htonl$, ^::htons$,
+   ^::iconv_open$, ^::inet_addr$, isascii$, isatty$, ^::mmap$, ^::newlocale$,
+   ^::openat$, ^::pathconf$, ^::pthread_equal$, ^::pthread_getspecific$,
+   ^::pthread_mutex_trylock$, ^::readdir$, ^::readlink$, ^::recvmsg$,
+   ^::regexec$, ^::scandir$, ^::semget$, ^::setjmp$, ^::shm_open$, ^::shmget$,
+   ^::sigismember$, ^::strcasecmp$, ^::strsignal$, ^::ttyname$``
 
    - ``std::async()``. Not using the return value makes the call synchronous.
    - ``std::launder()``. Not using the return value usually means that the
@@ -54,7 +57,8 @@ Options
 
    Semicolon-separated list of function return types to check.
    By default the following function return types are checked:
-   `::std::error_code`, `::std::error_condition`, `::std::errc`, `::std::expected`, `::boost::system::error_code`
+   `^::std::error_code$`, `^::std::error_condition$`, `^::std::errc$`,
+   `^::std::expected$`, `^::boost::system::error_code$`
 
 .. option:: AllowCastToVoid