Clean up getSInt32

andykaylor · andykaylor · commit 6143ed63517a · 2025-05-01T09:06:58.000-07:00
diff --git a/clang/lib/CIR/CodeGen/CIRGenBuilder.h b/clang/lib/CIR/CodeGen/CIRGenBuilder.h
@@ -190,8 +190,7 @@ class CIRGenBuilderTy : public cir::CIRBaseBuilderTy {
   // -------------------------
   //
   cir::ConstantOp getSInt32(int32_t c, mlir::Location loc) {
-    auto sInt32Ty = getSInt32Ty();
-    return create<cir::ConstantOp>(loc, cir::IntAttr::get(sInt32Ty, c));
+    return getConstantInt(loc, getSInt32Ty(), c);
   }
 
   // Creates constant nullptr for pointer type ty.

Original file line number	Diff line number	Diff line change
`@@ -190,8 +190,7 @@ class CIRGenBuilderTy : public cir::CIRBaseBuilderTy {`
`190`	`190`	`// -------------------------`
`191`	`191`	`//`
`192`	`192`	`cir::ConstantOp getSInt32(int32_t c, mlir::Location loc) {`
`193`		`- auto sInt32Ty = getSInt32Ty();`
`194`		`- return create<cir::ConstantOp>(loc, cir::IntAttr::get(sInt32Ty, c));`
	`193`	`+ return getConstantInt(loc, getSInt32Ty(), c);`
`195`	`194`	`}`
`196`	`195`
`197`	`196`	`// Creates constant nullptr for pointer type ty.`