Skip to content

Commit 61e7984

Browse files
committed
fixup! fixup! [mlir][vector][nfc] Add tests + update docs for narrow-type emulation
Refine the comment
1 parent eef52e2 commit 61e7984

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

mlir/lib/Dialect/Vector/Transforms/VectorEmulateNarrowType.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -324,30 +324,30 @@ struct ConvertVectorMaskedStore final
324324

325325
// Load the whole data and use arith.select to handle the corner cases.
326326
//
327-
// As an example, for this masked store:
327+
// As an example, for this masked store of i4 values:
328328
//
329329
// vector.maskedstore %0[%c0, %c0], %mask, %val_to_store
330330
//
331-
// and given these input i4 values:
331+
// and given these input values:
332332
//
333-
// %mask = [1, 1, 1, 1, 1, 0, 0, 0] (8 * i1)
333+
// %mask = [0, 1, 1, 1, 1, 0, 0, 0] (8 * i1)
334334
// %0[%c0, %c0] =
335335
// [0x1, 0x2, 0x3, 0x4, 0x5, 0x6, 0x7, 0x8] (8 * i4)
336336
// %val_to_store =
337337
// [0x9, 0xA, 0xB, 0xC, 0xD, 0xE, 0xF, 0x0] (8 * i4)
338338
//
339339
// we'll have the following i4 output:
340340
//
341-
// expected output: [0x9, 0xA, 0xB, 0xC, 0xD, 0x6, 0x7, 0x8]
341+
// expected output: [0x1, 0xA, 0xB, 0xC, 0xD, 0x6, 0x7, 0x8]
342342
//
343343
// Emulating the above using i8 will give:
344344
//
345345
// %compressed_mask = [1, 1, 1, 0] (4 * i1)
346346
// %maskedload = [0x12, 0x34, 0x56, 0x00] (4 * i8)
347347
// %bitcast = [0x1, 0x2, 0x3, 0x4, 0x5, 0x6, 0x0, 0x0] (8 * i4)
348348
// %select_using_shifted_mask =
349-
// [0x9, 0xA, 0xB, 0xC, 0xD, 0x6, 0x0, 0x0] (8 * i4)
350-
// %packed_data = [0x9A, 0xBC, 0xD6, 0x00] (4 * i8)
349+
// [0x1, 0xA, 0xB, 0xC, 0xD, 0x6, 0x0, 0x0] (8 * i4)
350+
// %packed_data = [0x1A, 0xBC, 0xD6, 0x00] (4 * i8)
351351
//
352352
// Using the compressed mask to store %packed_data results in expected
353353
// output.

0 commit comments

Comments
 (0)