Skip to content

Commit 6297e47

Browse files
committed
address comments
1 parent f0451dc commit 6297e47

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

mlir/lib/Dialect/Vector/Transforms/VectorDistribute.cpp

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,8 @@
1717
#include "mlir/IR/AffineExpr.h"
1818
#include "mlir/IR/Attributes.h"
1919
#include "mlir/IR/BuiltinTypes.h"
20-
#include "mlir/IR/Value.h"
2120
#include "mlir/Interfaces/SideEffectInterfaces.h"
22-
#include "mlir/Support/LLVM.h"
2321
#include "mlir/Transforms/RegionUtils.h"
24-
#include "llvm/ADT/DenseMap.h"
25-
#include "llvm/ADT/STLExtras.h"
2622
#include "llvm/ADT/SetVector.h"
2723
#include "llvm/ADT/SmallVectorExtras.h"
2824
#include "llvm/Support/FormatVariadic.h"
@@ -1787,11 +1783,11 @@ struct WarpOpScfForOp : public WarpDistributionPattern {
17871783
// index and the corresponding new `WarpOp` yield value index (needed to
17881784
// update users later).
17891785
llvm::SmallDenseMap<unsigned, unsigned> nonForResultMapping;
1790-
for (auto [i, v] : llvm::enumerate(nonForYieldedValues)) {
1791-
nonForResultMapping[nonForResultIndices[i]] = newWarpOpYieldValues.size();
1786+
for (auto [i, v] :
1787+
llvm::zip_equal(nonForResultIndices, nonForYieldedValues)) {
1788+
nonForResultMapping[i] = newWarpOpYieldValues.size();
17921789
newWarpOpYieldValues.push_back(v);
1793-
newWarpOpDistTypes.push_back(
1794-
warpOp.getResult(nonForResultIndices[i]).getType());
1790+
newWarpOpDistTypes.push_back(warpOp.getResult(i).getType());
17951791
}
17961792
// Create the new `WarpOp` with the updated yield values and types.
17971793
WarpExecuteOnLane0Op newWarpOp = moveRegionToNewWarpOpAndReplaceReturns(

0 commit comments

Comments
 (0)