Skip to content

Commit 62e0e8e

Browse files
committed
code review feedback
1 parent 2edef3b commit 62e0e8e

File tree

1 file changed

+11
-9
lines changed

1 file changed

+11
-9
lines changed

llvm/lib/Target/DirectX/DXILResourceImplicitBinding.cpp

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -135,15 +135,17 @@ PreservedAnalyses DXILResourceImplicitBinding::run(Module &M,
135135

136136
DXILResourceBindingInfo &DRBI = AM.getResult<DXILResourceBindingAnalysis>(M);
137137
DXILResourceTypeMap &DRTM = AM.getResult<DXILResourceTypeAnalysis>(M);
138-
if (DRBI.hasImplicitBinding()) {
139-
if (assignBindings(M, DRBI, DRTM)) {
140-
PreservedAnalyses PA;
141-
PA.preserve<DXILResourceBindingAnalysis>();
142-
PA.preserve<DXILResourceTypeAnalysis>();
143-
return PA;
144-
}
145-
}
146-
return PreservedAnalyses::all();
138+
139+
if (!DRBI.hasImplicitBinding())
140+
return PreservedAnalyses::all();
141+
142+
if (!assignBindings(M, DRBI, DRTM))
143+
return PreservedAnalyses::all();
144+
145+
PreservedAnalyses PA;
146+
PA.preserve<DXILResourceBindingAnalysis>();
147+
PA.preserve<DXILResourceTypeAnalysis>();
148+
return PA;
147149
}
148150

149151
namespace {

0 commit comments

Comments
 (0)