Skip to content

Commit 6314d5a

Browse files
committed
Address feedback, comment on target kind
1 parent 002af0c commit 6314d5a

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

llvm/lib/MC/MCInst.cpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,15 +68,17 @@ bool MCOperand::isBareSymbolRef() const {
6868
}
6969

7070
bool MCOperand::isSimpleSymbolRef(MCExpr::Spec &Specifier) const {
71-
assert(isExpr() && "isBareSymbolRef expects only expressions");
71+
assert(isExpr() && "isSimpleSymbolRef expects only expressions");
7272
const MCExpr *Expr = getExpr();
7373
MCExpr::ExprKind Kind = getExpr()->getKind();
7474

7575
switch (Kind) {
7676
case MCExpr::Binary:
7777
case MCExpr::Unary:
7878
case MCExpr::Constant:
79+
break;
7980
case MCExpr::Target:
81+
// It's not clear this is right, does MCTargetExpr need another virtual method?
8082
break;
8183
case MCExpr::SymbolRef:
8284
Specifier = cast<MCSymbolRefExpr>(Expr)->getSpecifier();

0 commit comments

Comments
 (0)