Skip to content

Commit 63492b1

Browse files
committed
Addressed review comments
1 parent 3476780 commit 63492b1

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

libc/src/unistd/fchown.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
//
77
//===----------------------------------------------------------------------===//
88

9-
#ifndef LLVM_LIBC_SRC_UNISTD_FCHOWN_H_
10-
#define LLVM_LIBC_SRC_UNISTD_FCHOWN_H_
9+
#ifndef LLVM_LIBC_SRC_UNISTD_FCHOWN_H
10+
#define LLVM_LIBC_SRC_UNISTD_FCHOWN_H
1111

1212
#include "hdr/types/gid_t.h"
1313
#include "hdr/types/uid_t.h"
@@ -19,4 +19,4 @@ int fchown(int fildes, uid_t owner, gid_t group);
1919

2020
} // namespace LIBC_NAMESPACE_DECL
2121

22-
#endif // LLVM_LIBC_SRC_UNISTD_FCHOWN_H_
22+
#endif // LLVM_LIBC_SRC_UNISTD_FCHOWN_H

libc/src/unistd/linux/fchown.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@
1111
#include "src/__support/OSUtil/syscall.h" // For internal syscall function.
1212
#include "src/__support/common.h"
1313

14+
#include "hdr/types/gid_t.h"
15+
#include "hdr/types/uid_t.h"
1416
#include "src/__support/libc_errno.h"
1517
#include "src/__support/macros/config.h"
1618
#include <sys/syscall.h> // For syscall numbers.

libc/test/src/unistd/fchown_test.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ TEST_F(LlvmLibcFchownTest, FchownSuccess) {
4444
ASSERT_THAT(LIBC_NAMESPACE::unlink(TEST_FILE), Succeeds(0));
4545
}
4646

47-
TEST_F(LlvmLibcFchownTest, ChownInvalidFileDescriptor) {
47+
TEST_F(LlvmLibcFchownTest, FchownInvalidFileDescriptor) {
4848
using LIBC_NAMESPACE::testing::ErrnoSetterMatcher::Fails;
4949
ASSERT_THAT(LIBC_NAMESPACE::fchown(-1, 1000, 1000), Fails(EBADF));
5050
}

0 commit comments

Comments
 (0)