Call BatchAA.alias() only once then check AAResult

Author: haopliu

llvm/include/llvm/Analysis/AliasAnalysis.h

@@ -667,10 +667,6 @@ class BatchAAResults {
                  MemoryLocation(V2, LocationSize::precise(1))) ==
            AliasResult::MustAlias;
   }
-  bool isNoAlias(const Value *V1, const Value *V2) {
-    return alias(MemoryLocation::getBeforeOrAfter(V1),
-                 MemoryLocation::getBeforeOrAfter(V2)) == AliasResult::NoAlias;
-  }
   ModRefInfo callCapturesBefore(const Instruction *I,
                                 const MemoryLocation &MemLoc,
                                 DominatorTree *DT) {

llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp

@@ -910,9 +910,11 @@ getInitializesArgMemLoc(const Instruction *I, BatchAAResults &BatchAA) {
     Value *CurArg = CB->getArgOperand(Idx);
     bool FoundAliasing = false;
     for (auto &[Arg, AliasList] : Arguments) {
-      if (BatchAA.isNoAlias(Arg, CurArg)) {
+      auto AAR = BatchAA.alias(MemoryLocation::getBeforeOrAfter(Arg),
+                               MemoryLocation::getBeforeOrAfter(CurArg));
+      if (AAR == AliasResult::NoAlias) {
         continue;
-      } else if (BatchAA.isMustAlias(Arg, CurArg)) {
+      } else if (AAR == AliasResult::MustAlias) {
         FoundAliasing = true;
         AliasList.push_back(InitInfo);
       } else {