Renaming this function to be more clear that it is not just a lang opt

Author: ojhunt

clang/include/clang/Sema/Sema.h

@@ -2135,7 +2135,7 @@ class Sema final : public SemaBase {
            isConstantEvaluatedOverride;
   }
 
-  bool AllowTypeAwareAllocators() const {
+  bool AllowTypeAwareAllocatorsInCurrentContext() const {
     return getLangOpts().TypeAwareAllocators && !isConstantEvaluatedContext();
   }
 

clang/lib/Sema/SemaCoroutine.cpp

@@ -1113,7 +1113,7 @@ static bool findDeleteForPromise(Sema &S, SourceLocation Loc, QualType PromiseTy
   // scope of the promise type. If nothing is found, a search is performed in
   // the global scope.
   ImplicitDeallocationParameters IDP = {
-      typeAwareAllocation(S.AllowTypeAwareAllocators()),
+      typeAwareAllocation(S.AllowTypeAwareAllocatorsInCurrentContext()),
       alignedAllocation(Overaligned), SizedDeallocation::Yes};
   if (S.FindDeallocationFunction(Loc, PointeeRD, DeleteName, OperatorDelete,
                                  PromiseType, IDP, /*Diagnose*/ true))
@@ -1426,7 +1426,7 @@ bool CoroutineStmtBuilder::makeNewAndDeleteExpr() {
   // Helper function to indicate whether the last lookup found the aligned
   // allocation function.
   ImplicitAllocationParameters IAP = {
-      typeAwareAllocation(S.AllowTypeAwareAllocators()),
+      typeAwareAllocation(S.AllowTypeAwareAllocatorsInCurrentContext()),
       alignedAllocation(S.getLangOpts().CoroAlignedAllocation)};
   auto LookupAllocationFunction =
       [&](Sema::AllocationFunctionScope NewScope = Sema::AFS_Both,
@@ -1442,7 +1442,7 @@ bool CoroutineStmtBuilder::makeNewAndDeleteExpr() {
         if (NewScope == Sema::AFS_Both)
           NewScope = PromiseContainsNew ? Sema::AFS_Class : Sema::AFS_Global;
 
-        IAP = {typeAwareAllocation(S.AllowTypeAwareAllocators()),
+        IAP = {typeAwareAllocation(S.AllowTypeAwareAllocatorsInCurrentContext()),
                alignedAllocation(!ForceNonAligned &&
                                  S.getLangOpts().CoroAlignedAllocation)};
 

clang/lib/Sema/SemaDeclCXX.cpp

@@ -9715,7 +9715,7 @@ bool Sema::ShouldDeleteSpecialMember(CXXMethodDecl *MD,
     DeclarationName Name =
       Context.DeclarationNames.getCXXOperatorName(OO_Delete);
     ImplicitDeallocationParameters IDP = {
-        typeAwareAllocation(AllowTypeAwareAllocators()), AlignedAllocation::No,
+        typeAwareAllocation(AllowTypeAwareAllocatorsInCurrentContext()), AlignedAllocation::No,
         SizedDeallocation::No};
     if (FindDeallocationFunction(MD->getLocation(), MD->getParent(), Name,
                                  OperatorDelete, DeallocType, IDP,
@@ -16159,7 +16159,7 @@ bool Sema::isTypeAwareOperatorNewOrDelete(const NamedDecl *ND) const {
 std::optional<FunctionDecl *>
 Sema::instantiateTypeAwareUsualDelete(FunctionTemplateDecl *FnTemplateDecl,
                                       QualType DeallocType) {
-  if (!AllowTypeAwareAllocators())
+  if (!AllowTypeAwareAllocatorsInCurrentContext())
     return std::nullopt;
 
   TemplateParameterList *TemplateParameters =
@@ -16234,7 +16234,7 @@ Sema::instantiateTypeAwareUsualDelete(FunctionTemplateDecl *FnTemplateDecl,
 
 std::optional<QualType>
 Sema::instantiateSpecializedTypeIdentity(QualType Subject) {
-  assert(AllowTypeAwareAllocators());
+  assert(AllowTypeAwareAllocatorsInCurrentContext());
   ClassTemplateDecl *TypeIdentity = getStdTypeIdentity();
   if (!TypeIdentity)
     return std::nullopt;

clang/lib/Sema/SemaExprCXX.cpp

@@ -1754,7 +1754,7 @@ static bool isNonPlacementDeallocationFunction(Sema &S, FunctionDecl *FD) {
     return false;
 
   unsigned UsualParams = 1;
-  if (S.AllowTypeAwareAllocators() && UsualParams < FD->getNumParams() &&
+  if (S.AllowTypeAwareAllocatorsInCurrentContext() && UsualParams < FD->getNumParams() &&
       S.isTypeAwareOperatorNewOrDelete(FD))
     ++UsualParams;
 
@@ -1795,7 +1795,7 @@ namespace {
         FD = *InstantiatedDecl;
       }
       unsigned NumBaseParams = 1;
-      if (S.AllowTypeAwareAllocators() &&
+      if (S.AllowTypeAwareAllocatorsInCurrentContext() &&
           S.isTypeAwareOperatorNewOrDelete(FD)) {
         QualType TypeIdentityTag = FD->getParamDecl(0)->getType();
         std::optional<QualType> ExpectedTypeIdentityTag =
@@ -2432,7 +2432,7 @@ ExprResult Sema::BuildCXXNew(SourceRange Range, bool UseGlobal,
       AllocType->isDependentType() ? 0 : Context.getTypeAlign(AllocType);
   unsigned NewAlignment = Context.getTargetInfo().getNewAlign();
   ImplicitAllocationParameters IAP = {
-      typeAwareAllocation(AllowTypeAwareAllocators()),
+      typeAwareAllocation(AllowTypeAwareAllocatorsInCurrentContext()),
       alignedAllocation(getLangOpts().AlignedAllocation &&
                         Alignment > NewAlignment)};
 
@@ -3509,7 +3509,7 @@ FunctionDecl *Sema::FindUsualDeallocationFunction(
   DeclareGlobalNewDelete();
 
   LookupResult FoundDelete(*this, Name, StartLoc, LookupOrdinaryName);
-  DeallocLookupMode LookupMode = AllowTypeAwareAllocators()
+  DeallocLookupMode LookupMode = AllowTypeAwareAllocatorsInCurrentContext()
                                      ? DeallocLookupMode::OptionallyTyped
                                      : DeallocLookupMode::Untyped;
   LookupGlobalDeallocationFunctions(*this, StartLoc, FoundDelete, LookupMode,
@@ -3540,7 +3540,7 @@ FunctionDecl *Sema::FindDeallocationFunctionForDestructor(SourceLocation Loc,
   FunctionDecl *OperatorDelete = nullptr;
   QualType DeallocType = Context.getRecordType(RD);
   ImplicitDeallocationParameters IDP = {
-      typeAwareAllocation(AllowTypeAwareAllocators()), AlignedAllocation::No,
+      typeAwareAllocation(AllowTypeAwareAllocatorsInCurrentContext()), AlignedAllocation::No,
       SizedDeallocation::No};
 
   if (FindDeallocationFunction(Loc, RD, Name, OperatorDelete, DeallocType, IDP))
@@ -4012,7 +4012,7 @@ Sema::ActOnCXXDelete(SourceLocation StartLoc, bool UseGlobal,
 
     if (PointeeRD) {
       ImplicitDeallocationParameters IDP = {
-          typeAwareAllocation(AllowTypeAwareAllocators()),
+          typeAwareAllocation(AllowTypeAwareAllocatorsInCurrentContext()),
           AlignedAllocation::No, SizedDeallocation::No};
       if (!UseGlobal &&
           FindDeallocationFunction(StartLoc, PointeeRD, DeleteName,
@@ -4066,7 +4066,7 @@ Sema::ActOnCXXDelete(SourceLocation StartLoc, bool UseGlobal,
 
       // Look for a global declaration.
       ImplicitDeallocationParameters IDP = {
-          typeAwareAllocation(AllowTypeAwareAllocators()),
+          typeAwareAllocation(AllowTypeAwareAllocatorsInCurrentContext()),
           alignedAllocation(Overaligned), sizedDeallocation(CanProvideSize)};
       OperatorDelete =
           FindUsualDeallocationFunction(Pointee, StartLoc, IDP, DeleteName);