Address comments.

Author: lntue

libc/src/math/generic/CMakeLists.txt

@@ -4097,12 +4097,16 @@ add_entrypoint_object(
   HDRS
     ../asin.h
   DEPENDS
+    libc.src.__support.FPUtil.fp_bits
+    libc.src.__support.FPUtil.double_double
+    libc.src.__support.FPUtil.dyadic_float
+    libc.src.__support.FPUtil.fenv_impl
     libc.src.__support.FPUtil.fp_bits
     libc.src.__support.FPUtil.multiply_add
-    libc.src.__support.FPUtil.polyeval
+    libc.src.__support.FPUtil.poly_eval
     libc.src.__support.FPUtil.sqrt
     libc.src.__support.macros.optimization
-    .inv_trigf_utils
+    libc.src.__support.macros.properties.cpu_features
 )
 
 add_entrypoint_object(

libc/src/math/generic/asin.cpp

@@ -25,7 +25,7 @@ using DoubleDouble = fputil::DoubleDouble;
 using Float128 = fputil::DyadicFloat<128>;
 
 LLVM_LIBC_FUNCTION(double, asin, (double x)) {
-  using FPBits = typename fputil::FPBits<double>;
+  using FPBits = fputil::FPBits<double>;
 
   FPBits xbits(x);
   int x_exp = xbits.get_biased_exponent();
@@ -138,6 +138,8 @@ LLVM_LIBC_FUNCTION(double, asin, (double x)) {
     if (xbits.is_finite()) {
       fputil::set_errno_if_required(EDOM);
       fputil::raise_except_if_required(FE_INVALID);
+    } else if (xbits.is_signaling_nan()) {
+      fputil::raise_except_if_required(FE_INVALID);
     }
     return FPBits::quiet_nan().get_val();
   }
@@ -201,7 +203,7 @@ LLVM_LIBC_FUNCTION(double, asin, (double x)) {
   // Polynomial approximation:
   //   p ~ asin(sqrt(u))/sqrt(u)
   unsigned idx;
-  [[maybe_unused]] double err = vh * 0x1.0p-51;
+  double err = vh * 0x1.0p-51;
 
   DoubleDouble p = asin_eval(DoubleDouble{0.0, u}, idx, err);
 

libc/src/math/generic/asin_utils.h

@@ -205,28 +205,24 @@ LIBC_INLINE DoubleDouble asin_eval(const DoubleDouble &u, unsigned &idx,
 // };
 // > verbosity = 0;
 // > procedure ASIN_APPROX(N, Deg) {
-//   abs_error = 0;
-//   rel_error = 0;
-//     for
-//       i from 1 to N / 4 do {
-//         Q = fpminimax(asin(sqrt(i / N + x)) / sqrt(i / N + x), Deg,
-//                       [| 128... | ], [ -1 / (2 * N), 1 / (2 * N) ]);
-//         abs_err = dirtyinfnorm(asin(sqrt(i / N + x)) - sqrt(i / N + x) * Q,
-//                                [ -1 / (2 * N), 1 / (2 * N) ]);
-//         rel_err = dirtyinfnorm(asin(sqrt(i / N + x)) / sqrt(i / N + x) - Q,
-//                                [ -1 / (2 * N), 1 / (2 * N) ]);
-//         if (abs_err > abs_error)
-//           then abs_error = abs_err;
-//         if (rel_err > rel_error)
-//           then rel_error = rel_err;
-//         write("{");
-//       for
-//         j from 0 to Deg do PRINTF128(coeff(Q, j));
+//     abs_error = 0;
+//     rel_error = 0;
+//     for i from 1 to N / 4 do {
+//       Q = fpminimax(asin(sqrt(i / N + x)) / sqrt(i / N + x), Deg,
+//                     [| 128... | ], [ -1 / (2 * N), 1 / (2 * N) ]);
+//       abs_err = dirtyinfnorm(asin(sqrt(i / N + x)) - sqrt(i / N + x) * Q,
+//                              [ -1 / (2 * N), 1 / (2 * N) ]);
+//       rel_err = dirtyinfnorm(asin(sqrt(i / N + x)) / sqrt(i / N + x) - Q,
+//                              [ -1 / (2 * N), 1 / (2 * N) ]);
+//       if (abs_err > abs_error) then abs_error = abs_err;
+//       if (rel_err > rel_error) then rel_error = rel_err;
+//       write("{");
+//       for j from 0 to Deg do PRINTF128(coeff(Q, j));
 //       print("},");
-//       };
+//     };
 //     print("Absolute Errors:", abs_error);
 //     print("Relative Errors:", rel_error);
-// };
+//   };
 // > ASIN_APPROX(64, 15);
 // ...
 // Absolute Errors: 0x1.0b3...p-129

libc/test/src/math/asin_test.cpp

@@ -6,7 +6,6 @@
 //
 //===----------------------------------------------------------------------===//
 
-#include "src/__support/FPUtil/FPBits.h"
 #include "src/math/asin.h"
 #include "test/UnitTest/FPMatcher.h"
 #include "test/UnitTest/Test.h"
@@ -20,8 +19,8 @@ using LIBC_NAMESPACE::testing::tlog;
 
 TEST_F(LlvmLibcAsinTest, InDoubleRange) {
   constexpr uint64_t COUNT = 123'451;
-  uint64_t START = LIBC_NAMESPACE::fputil::FPBits<double>(0x1.0p-60).uintval();
-  uint64_t STOP = LIBC_NAMESPACE::fputil::FPBits<double>(1.0).uintval();
+  uint64_t START = FPBits(0x1.0p-60).uintval();
+  uint64_t STOP = FPBits(1.0).uintval();
   uint64_t STEP = (STOP - START) / COUNT;
 
   auto test = [&](mpfr::RoundingMode rounding_mode) {
@@ -32,7 +31,7 @@ TEST_F(LlvmLibcAsinTest, InDoubleRange) {
     uint64_t fails = 0;
     uint64_t count = 0;
     uint64_t cc = 0;
-    double mx, mr = 0.0;
+    double mx = 0.0, mr = 0.0;
     double tol = 0.5;
 
     for (uint64_t i = 0, v = START; i <= COUNT; ++i, v += STEP) {

libc/test/src/math/smoke/CMakeLists.txt

@@ -4014,7 +4014,6 @@ add_fp_unittest(
     asin_test.cpp
   DEPENDS
     libc.src.math.asin
-    libc.src.__support.FPUtil.fp_bits
 )
 
 add_fp_unittest(

libc/test/src/math/smoke/asin_test.cpp

@@ -6,14 +6,17 @@
 //
 //===----------------------------------------------------------------------===//
 
-#include "hdr/math_macros.h"
+#include "hdr/fenv_macros.h"
 #include "src/math/asin.h"
 #include "test/UnitTest/FPMatcher.h"
 #include "test/UnitTest/Test.h"
 
 using LlvmLibcAsinTest = LIBC_NAMESPACE::testing::FPTest<double>;
 
 TEST_F(LlvmLibcAsinTest, SpecialNumbers) {
+  EXPECT_FP_EQ_WITH_EXCEPTION_ALL_ROUNDING(aNaN, LIBC_NAMESPACE::asin(sNaN),
+                                           FE_INVALID);
+  EXPECT_FP_EQ_ALL_ROUNDING(aNaN, LIBC_NAMESPACE::asin(aNaN));
   EXPECT_FP_EQ_ALL_ROUNDING(aNaN, LIBC_NAMESPACE::asin(aNaN));
   EXPECT_FP_EQ_ALL_ROUNDING(zero, LIBC_NAMESPACE::asin(zero));
   EXPECT_FP_EQ_ALL_ROUNDING(neg_zero, LIBC_NAMESPACE::asin(neg_zero));