Rename access() to getBlobMap()

Author: andrey-golubev

mlir/include/mlir/IR/DialectResourceBlobManager.h

@@ -94,9 +94,9 @@ class DialectResourceBlobManager {
   }
 
   /// Provide access to all the registered blobs via a callable. During access
-  /// the blobs are guaranteed to remain unchanged.
-  void access(llvm::function_ref<void(const llvm::StringMap<BlobEntry> &)>
-                  accessor) const;
+  /// the blob map is guaranteed to remain unchanged.
+  void getBlobMap(llvm::function_ref<void(const llvm::StringMap<BlobEntry> &)>
+                      accessor) const;
 
 private:
   /// A mutex to protect access to the blob map.

mlir/lib/IR/DialectResourceBlobManager.cpp

@@ -64,7 +64,7 @@ auto DialectResourceBlobManager::insert(StringRef name,
   } while (true);
 }
 
-void DialectResourceBlobManager::access(
+void DialectResourceBlobManager::getBlobMap(
     llvm::function_ref<void(const llvm::StringMap<BlobEntry> &)> accessor)
     const {
   llvm::sys::SmartScopedReader<true> reader(blobMapLock);

mlir/unittests/IR/BlobManagerTest.cpp

@@ -40,7 +40,7 @@ TEST(DialectResourceBlobManagerTest, Lookup) {
   ASSERT_NE(dialectManager.getBlobManager().lookup("blob1"), nullptr);
 }
 
-TEST(DialectResourceBlobManagerTest, Access) {
+TEST(DialectResourceBlobManagerTest, GetBlobMap) {
   MLIRContext context;
   context.loadDialect<test::TestDialect>();
 
@@ -56,7 +56,7 @@ TEST(DialectResourceBlobManagerTest, Access) {
       resourceAttr.getRawHandle().getManagerInterface(&context);
 
   bool blobsArePresent = false;
-  dialectManager.getBlobManager().access(
+  dialectManager.getBlobManager().getBlobMap(
       [&](const llvm::StringMap<DialectResourceBlobManager::BlobEntry>
               &blobMap) { blobsArePresent = blobMap.contains("blob1"); });
   ASSERT_TRUE(blobsArePresent);
@@ -65,7 +65,7 @@ TEST(DialectResourceBlobManagerTest, Access) {
   block->clear();
 
   blobsArePresent = false;
-  dialectManager.getBlobManager().access(
+  dialectManager.getBlobManager().getBlobMap(
       [&](const llvm::StringMap<DialectResourceBlobManager::BlobEntry>
               &blobMap) { blobsArePresent = blobMap.contains("blob1"); });
   ASSERT_TRUE(blobsArePresent);