Skip to content

Commit 641b437

Browse files
update godbolt link and add TODO to a64l
1 parent 723e838 commit 641b437

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

libc/src/stdlib/a64l.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ constexpr static int32_t b64_char_to_int(char ch) {
4040

4141
// This function takes a base 64 string and writes it to the low 32 bits of a
4242
// long.
43+
// TODO: use LIBC_ADD_NULL_CHECKS for checking if the input is a null pointer.
4344
LLVM_LIBC_FUNCTION(long, a64l, (const char *s)) {
4445
// the standard says to only use up to 6 characters.
4546
constexpr size_t MAX_LENGTH = 6;

libc/src/stdlib/l64a.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ constexpr static char b64_int_to_char(uint32_t num) {
3939
// this tolower is technically unnecessary, but it provides safety if we
4040
// change the default behavior of int_to_b36_char. Also the compiler
4141
// completely elides it so there's no performance penalty, see:
42-
// https://godbolt.org/z/sfxdhYvYb TODO: UPDATE THIS LINK
42+
// https://godbolt.org/z/o5ennv7fc
4343
return static_cast<char>(
4444
internal::tolower(internal::int_to_b36_char(num - 2 - 26)));
4545
}

0 commit comments

Comments
 (0)