more cleanups

Author: cor3ntin

clang/include/clang/AST/ASTConcept.h

@@ -44,7 +44,6 @@ using UnsatisfiedConstraintRecord =
 /// The result of a constraint satisfaction check, containing the necessary
 /// information to diagnose an unsatisfied constraint.
 class ConstraintSatisfaction : public llvm::FoldingSetNode {
-private:
   // The template-like entity that 'owns' the constraint checked here (can be a
   // constrained entity or a concept).
   const NamedDecl *ConstraintOwner = nullptr;

clang/lib/Sema/SemaConcept.cpp

@@ -508,10 +508,7 @@ StringRef allocateStringFromConceptDiagnostic(const Sema &S,
   SmallString<128> DiagString;
   DiagString = ": ";
   Diag.EmitToString(S.getDiagnostics(), DiagString);
-  unsigned MessageSize = DiagString.size();
-  char *Mem = new (S.Context) char[MessageSize];
-  memcpy(Mem, DiagString.c_str(), MessageSize);
-  return StringRef(Mem, MessageSize);
+  return S.getASTContext().backupStr(DiagString);
 }
 
 } // namespace