review comments addressed

Author: midhuncodes7

llvm/include/llvm/DebugInfo/Symbolize/Symbolize.h

@@ -29,12 +29,6 @@
 #include <utility>
 #include <vector>
 
-#ifdef _AIX
-#define SYMBOLIZE_AIX 1
-#else
-#define SYMBOLIZE_AIX 0
-#endif
-
 namespace llvm {
 namespace object {
 class ELFObjectFileBase;
@@ -210,9 +204,9 @@ class LLVMSymbolizer {
 
   /// Return a pointer to object file at specified path, for a specified
   /// architecture that is present inside an archive file
-  Expected<ObjectFile *>
-  getOrCreateObjectFromArchive(StringRef ArchivePath, StringRef MemberName,
-                               StringRef ArchName);
+  Expected<ObjectFile *> getOrCreateObjectFromArchive(StringRef ArchivePath,
+                                                      StringRef MemberName,
+                                                      StringRef ArchName);
 
   /// Update the LRU cache order when a binary is accessed.
   void recordAccess(CachedBinary &Bin);
@@ -252,7 +246,7 @@ class LLVMSymbolizer {
 
   std::map<ArchiveCacheKey, std::unique_ptr<ObjectFile>>
       ObjectForArchivePathAndArch;
-  
+
   Options Opts;
 
   std::unique_ptr<BuildIDFetcher> BIDFetcher;

llvm/test/DebugInfo/symbolize-big-archive-elf.test

@@ -10,9 +10,11 @@
 
 // Test symbolization by member name (using just base names)
 // RUN: MEMBER1=$(basename %t-1.o)
-// RUN: llvm-symbolizer --default-arch=ppc64 --obj="%t.a($MEMBER1)" 0x0 | FileCheck %s --check-prefix=CHECK-1
+// RUN: llvm-symbolizer --default-arch=ppc64le --obj="%t.a($MEMBER1)" 0x0 | FileCheck %s --check-prefix=CHECK-1
+// RUN: llvm-symbolizer --obj="%t.a($MEMBER1):ppc64le" 0x0 | FileCheck %s --check-prefix=CHECK-1
 // RUN: MEMBER2=$(basename %t-2.o)
-// RUN: llvm-symbolizer --default-arch=ppc64 --obj="%t.a($MEMBER2)" 0x0 | FileCheck %s --check-prefix=CHECK-2
+// RUN: llvm-symbolizer --default-arch=ppc64le --obj="%t.a($MEMBER2)" 0x0 | FileCheck %s --check-prefix=CHECK-2
+// RUN: llvm-symbolizer --obj="%t.a($MEMBER2):ppc64le" 0x0 | FileCheck %s --check-prefix=CHECK-2
 // CHECK-1: foo1
 // CHECK-2: foo2
 

llvm/test/DebugInfo/symbolize-big-archive-xcoff.test

@@ -7,25 +7,12 @@
 // Create archive with same-named members using different modes
 // RUN: rm -f %t.a
 // RUN: cp %t-32.o %t.o
-// RUN: if [ "$(uname)" = "AIX" ]; then \
-          llvm-ar -X32 crv %t.a %t.o; \
-        else \
-          llvm-ar crv %t.a %t.o; \
-        fi
+// RUN: llvm-ar %if system-aix %{-X32%} crv %t.a %t.o
 // RUN: cp %t-64.o %t.o
-// RUN: if [ "$(uname)" = "AIX" ]; then \
-          llvm-ar -X64 rv %t.a %t.o; \
-        else \
-          llvm-ar qv %t.a %t.o; \
-        fi
-
+// RUN: llvm-ar %if system-aix %{-X64 rv%} %else %{qv%} %t.a %t.o
 
 // Verify archive contains two members with same name
-// RUN: if [ "$(uname)" = "AIX" ]; then \
-          llvm-ar tv -X32_64 %t.a | FileCheck %s --check-prefix=CHECK-ARCHIVE; \
-        else \
-          llvm-ar tv %t.a | FileCheck %s --check-prefix=CHECK-ARCHIVE; \
-        fi
+// RUN: llvm-ar tv %if system-aix %{-X32_64%} %t.a | FileCheck %s --check-prefix=CHECK-ARCHIVE
 // CHECK-ARCHIVE: {{.*}}symbolize-big-archive-xcoff.test.tmp.o{{$}}
 // CHECK-ARCHIVE: {{.*}}symbolize-big-archive-xcoff.test.tmp.o{{$}}