Skip to content

Commit 648848d

Browse files
committed
Address review feedback
1 parent 8139104 commit 648848d

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

clang/lib/CIR/CodeGen/CIRGenModule.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -781,17 +781,17 @@ cir::FuncOp CIRGenModule::getOrCreateCIRFunction(
781781
// In what follows, we continue past 'errorNYI' as if nothing happened because
782782
// the rest of the implementation is better than doing nothing.
783783

784-
// Any attempts to use a MultiVersion function should result in retrieving the
785-
// iFunc instead. Name mangling will handle the rest of the changes.
786784
if (const auto *fd = cast_or_null<FunctionDecl>(d)) {
787785
// For the device mark the function as one that should be emitted.
788786
if (getLangOpts().OpenMPIsTargetDevice && fd->isDefined() && !dontDefer &&
789787
!isForDefinition)
790788
errorNYI(fd->getSourceRange(),
791789
"getOrCreateCIRFunction: OpenMP target function");
792790

791+
// Any attempts to use a MultiVersion function should result in retrieving
792+
// the iFunc instead. Name mangling will handle the rest of the changes.
793793
if (fd->isMultiVersion())
794-
errorNYI(fd->getSourceRange(), "multi-version functions NYI");
794+
errorNYI(fd->getSourceRange(), "getOrCreateCIRFunction: multi-version");
795795
}
796796

797797
// Lookup the entry, lazily creating it if necessary.

clang/test/CIR/CodeGen/call.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ void f2() {
55
f1();
66
}
77

8-
// CHECK-LABEL: cir.func @_Z2f1v
8+
// CHECK-LABEL: cir.func @_Z2f1v
99
// CHECK-LABEL: cir.func @_Z2f2v
1010
// CHECK: cir.call @_Z2f1v() : () -> ()
1111

0 commit comments

Comments
 (0)