[Shape] Avoid repeated hash lookups (NFC) (#108926)

kazutakahirata · web-flow · commit 65a5b18aa040 · 2024-09-17T00:18:33.000-07:00
diff --git a/mlir/lib/Dialect/Shape/Transforms/OutlineShapeComputation.cpp b/mlir/lib/Dialect/Shape/Transforms/OutlineShapeComputation.cpp
@@ -292,10 +292,8 @@ void OutlineShapeComputationPass::getClusterFromValue(
       cluster.insert(op);
       for (Value inp : op->getOperands()) {
         Operation *inpDefOp = inp.getDefiningOp();
-        if (nullptr != inpDefOp && !visited.contains(inpDefOp)) {
-          visited.insert(inpDefOp);
+        if (nullptr != inpDefOp && visited.insert(inpDefOp).second)
           queue.push(inpDefOp);
-        }
       }
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -292,10 +292,8 @@ void OutlineShapeComputationPass::getClusterFromValue(`
`292`	`292`	`cluster.insert(op);`
`293`	`293`	`for (Value inp : op->getOperands()) {`
`294`	`294`	`Operation *inpDefOp = inp.getDefiningOp();`
`295`		`- if (nullptr != inpDefOp && !visited.contains(inpDefOp)) {`
`296`		`- visited.insert(inpDefOp);`
	`295`	`+ if (nullptr != inpDefOp && visited.insert(inpDefOp).second)`
`297`	`296`	`queue.push(inpDefOp);`
`298`		`- }`
`299`	`297`	`}`
`300`	`298`	`}`
`301`	`299`	`}`