File tree Expand file tree Collapse file tree 1 file changed +6
-6
lines changed
mlir/lib/Conversion/AMDGPUToROCDL Expand file tree Collapse file tree 1 file changed +6
-6
lines changed Original file line number Diff line number Diff line change @@ -544,13 +544,13 @@ struct LDSBarrierOpLowering : public ConvertOpToLLVMPattern<LDSBarrierOp> {
544544 Attribute mmra =
545545 rewriter.getAttr <LLVM::MMRATagAttr>(" amdgpu-synchronize-as" , " local" );
546546 // Note: while there *is* a workgroup-one-as scope, this, when combined with
547- // the MMRA, will lead to the fence having no effect. This is because
548- // the codepaths for an atomic load or store will observe that a
547+ // the MMRA, will lead to the fence having no effect. This is because the
548+ // codepaths for an atomic load or store will observe that a
549549 // one-address-space atomic to LDS requires no synchronization because
550- // operations on LDS are totally ordered with respect to each other,
551- // and so will not emit the correct waitcnt operations that these fences
552- // are intended to produce. Therefore, we use a broader type of fence
553- // and rely on the MMRA to relax it to the semantics we want.
550+ // operations on LDS are totally ordered with respect to each other, and so
551+ // will not emit the correct waitcnt operations that these fences are
552+ // intended to produce. Therefore, we use a broader type of fence and rely
553+ // on the MMRA to relax it to the semantics we want.
554554 StringRef scope = " workgroup" ;
555555
556556 auto relFence = LLVM::FenceOp::create (rewriter, loc,
You can’t perform that action at this time.
0 commit comments