[flang] Re-enable date_and_time intrinsic test (NFC) (#104967)

kkwli · web-flow · commit 66ab4b80a410 · 2024-08-20T15:47:15.000-04:00
diff --git a/flang/unittests/Runtime/Time.cpp b/flang/unittests/Runtime/Time.cpp
@@ -6,8 +6,6 @@
 //
 //===----------------------------------------------------------------------===//
 
-#ifndef __clang__ // 16.0.3 lacks <charconv>
-
 #include "gtest/gtest.h"
 #include "flang/Runtime/time-intrinsic.h"
 #include <algorithm>
@@ -89,6 +87,7 @@ TEST(TimeIntrinsics, SystemClock) {
 }
 
 TEST(TimeIntrinsics, DateAndTime) {
+  errno = 0;
   constexpr std::size_t bufferSize{16};
   std::string date(bufferSize, 'Z'), time(bufferSize, 'Z'),
       zone(bufferSize, 'Z');
@@ -163,4 +162,3 @@ TEST(TimeIntrinsics, DateAndTime) {
     EXPECT_LE(minutes, 59);
   }
 }
-#endif // __clang__

Original file line number	Diff line number	Diff line change
`@@ -6,8 +6,6 @@`
`6`	`6`	`//`
`7`	`7`	`//===----------------------------------------------------------------------===//`
`8`	`8`
`9`		`-#ifndef __clang__ // 16.0.3 lacks <charconv>`
`10`		`-`
`11`	`9`	`#include "gtest/gtest.h"`
`12`	`10`	`#include "flang/Runtime/time-intrinsic.h"`
`13`	`11`	`#include <algorithm>`
`@@ -89,6 +87,7 @@ TEST(TimeIntrinsics, SystemClock) {`
`89`	`87`	`}`
`90`	`88`
`91`	`89`	`TEST(TimeIntrinsics, DateAndTime) {`
	`90`	`+ errno = 0;`
`92`	`91`	`constexpr std::size_t bufferSize{16};`
`93`	`92`	`std::string date(bufferSize, 'Z'), time(bufferSize, 'Z'),`
`94`	`93`	`zone(bufferSize, 'Z');`
`@@ -163,4 +162,3 @@ TEST(TimeIntrinsics, DateAndTime) {`
`163`	`162`	`EXPECT_LE(minutes, 59);`
`164`	`163`	`}`
`165`	`164`	`}`
`166`		`-#endif // __clang__`