Skip to content

Commit 66d347b

Browse files
CarolineConcattoCarolineConcatto
authored
[Clang][AArch64]Make Tuple Size Optional for svluti4_lane Intrinsics (#123197)
The svluti4_lane intrinsic currently requires the tuple size to be specified in the intrinsic name when using a tuple type input. According to the ACLE specification, the svluti4_lane intrinsic with a tuple type input, such as: svint16_t svluti4_lane[_s16_x2(svint16x2_t table, svuint8_t indices, uint64_t imm_idx); should allow the tuple size of the input type to be optional.
1 parent a242880 commit 66d347b

File tree

3 files changed

+117
-117
lines changed

3 files changed

+117
-117
lines changed

‎clang/include/clang/Basic/arm_sve.td‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1954,13 +1954,13 @@ let SVETargetGuard = "sve2,lut", SMETargetGuard = "sme2,lut" in {
19541954
def SVLUTI4_B : SInst<"svluti4_lane[_{d}]", "dd[i", "cUc", MergeNone, "aarch64_sve_luti4_lane", [VerifyRuntimeMode], [ImmCheck<2, ImmCheck0_1>]>;
19551955
def SVLUTI4_H : SInst<"svluti4_lane[_{d}]", "dd[i", "sUsh", MergeNone, "aarch64_sve_luti4_lane", [VerifyRuntimeMode], [ImmCheck<2, ImmCheck0_3>]>;
19561956

1957-
def SVLUTI4_x2 : SInst<"svluti4_lane[_{d}]_x2", "d2.d[i", "sUsh", MergeNone, "aarch64_sve_luti4_lane_x2", [VerifyRuntimeMode], [ImmCheck<2, ImmCheck0_3>]>;
1957+
def SVLUTI4_x2 : SInst<"svluti4_lane[_{d}_x2]", "d2.d[i", "sUsh", MergeNone, "aarch64_sve_luti4_lane_x2", [VerifyRuntimeMode], [ImmCheck<2, ImmCheck0_3>]>;
19581958
}
19591959

19601960
let SVETargetGuard = "sve2,lut,bf16", SMETargetGuard = "sme2,lut,bf16" in {
19611961
def SVLUTI2_BF16 : SInst<"svluti2_lane[_{d}]", "dd[i", "b", MergeNone, "aarch64_sve_luti2_lane", [ VerifyRuntimeMode], [ImmCheck<2, ImmCheck0_7>]>;
19621962
def SVLUTI4_BF16 : SInst<"svluti4_lane[_{d}]", "dd[i", "b", MergeNone, "aarch64_sve_luti4_lane", [ VerifyRuntimeMode], [ImmCheck<2, ImmCheck0_3>]>;
1963-
def SVLUTI4_BF16_x2 : SInst<"svluti4_lane[_{d}]_x2", "d2.d[i", "b", MergeNone, "aarch64_sve_luti4_lane_x2", [ VerifyRuntimeMode], [ImmCheck<2, ImmCheck0_3>]>;
1963+
def SVLUTI4_BF16_x2 : SInst<"svluti4_lane[_{d}_x2]", "d2.d[i", "b", MergeNone, "aarch64_sve_luti4_lane_x2", [ VerifyRuntimeMode], [ImmCheck<2, ImmCheck0_3>]>;
19641964
}
19651965

19661966
////////////////////////////////////////////////////////////////////////////////

‎clang/test/CodeGen/AArch64/sve2-intrinsics/acle_sve2_luti.c‎

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@
1919

2020
#ifdef SVE_OVERLOADED_FORMS
2121
// A simple used,unused... macro, long enough to represent any SVE builtin.
22-
#define SVE_ACLE_FUNC(A1,A2_UNUSED,A3) A1##A3
22+
#define SVE_ACLE_FUNC(A1,A2_UNUSED) A1
2323
#else
24-
#define SVE_ACLE_FUNC(A1,A2,A3) A1##A2##A3
24+
#define SVE_ACLE_FUNC(A1,A2) A1##A2
2525
#endif
2626

2727
// SME-CHECK-LABEL: @test_svluti2_lane_s8(
@@ -39,7 +39,7 @@
3939
// CPP-CHECK-NEXT: ret <vscale x 16 x i8> [[TMP0]]
4040
//
4141
svint8_t test_svluti2_lane_s8(svint8_t table, svuint8_t indices) MODE_ATTR{
42-
return SVE_ACLE_FUNC(svluti2_lane,_s8,)(table, indices, 0);
42+
return SVE_ACLE_FUNC(svluti2_lane,_s8)(table, indices, 0);
4343
}
4444

4545
// SME-CHECK-LABEL: @test_svluti2_lane_u8(
@@ -57,7 +57,7 @@ svint8_t test_svluti2_lane_s8(svint8_t table, svuint8_t indices) MODE_ATTR{
5757
// CPP-CHECK-NEXT: ret <vscale x 16 x i8> [[TMP0]]
5858
//
5959
svuint8_t test_svluti2_lane_u8(svuint8_t table, svuint8_t indices) MODE_ATTR{
60-
return SVE_ACLE_FUNC(svluti2_lane,_u8,)(table, indices, 3);
60+
return SVE_ACLE_FUNC(svluti2_lane,_u8)(table, indices, 3);
6161
}
6262

6363
// SME-CHECK-LABEL: @test_svluti2_lane_s16(
@@ -75,7 +75,7 @@ svuint8_t test_svluti2_lane_u8(svuint8_t table, svuint8_t indices) MODE_ATTR{
7575
// CPP-CHECK-NEXT: ret <vscale x 8 x i16> [[TMP0]]
7676
//
7777
svint16_t test_svluti2_lane_s16(svint16_t table, svuint8_t indices) MODE_ATTR{
78-
return SVE_ACLE_FUNC(svluti2_lane,_s16,)(table, indices, 0);
78+
return SVE_ACLE_FUNC(svluti2_lane,_s16)(table, indices, 0);
7979
}
8080

8181
// SME-CHECK-LABEL: @test_svluti2_lane_u16(
@@ -93,7 +93,7 @@ svint16_t test_svluti2_lane_s16(svint16_t table, svuint8_t indices) MODE_ATTR{
9393
// CPP-CHECK-NEXT: ret <vscale x 8 x i16> [[TMP0]]
9494
//
9595
svuint16_t test_svluti2_lane_u16(svuint16_t table, svuint8_t indices) MODE_ATTR{
96-
return SVE_ACLE_FUNC(svluti2_lane,_u16,)(table, indices, 7);
96+
return SVE_ACLE_FUNC(svluti2_lane,_u16)(table, indices, 7);
9797
}
9898

9999
// SME-CHECK-LABEL: @test_svluti2_lane_f16(
@@ -111,7 +111,7 @@ svuint16_t test_svluti2_lane_u16(svuint16_t table, svuint8_t indices) MODE_ATTR{
111111
// CPP-CHECK-NEXT: ret <vscale x 8 x half> [[TMP0]]
112112
//
113113
svfloat16_t test_svluti2_lane_f16(svfloat16_t table, svuint8_t indices) MODE_ATTR{
114-
return SVE_ACLE_FUNC(svluti2_lane,_f16,)(table, indices, 5);
114+
return SVE_ACLE_FUNC(svluti2_lane,_f16)(table, indices, 5);
115115
}
116116

117117
// SME-CHECK-LABEL: @test_svluti2_lane_bf16(
@@ -129,7 +129,7 @@ svfloat16_t test_svluti2_lane_f16(svfloat16_t table, svuint8_t indices) MODE_ATT
129129
// CPP-CHECK-NEXT: ret <vscale x 8 x bfloat> [[TMP0]]
130130
//
131131
svbfloat16_t test_svluti2_lane_bf16(svbfloat16_t table, svuint8_t indices) MODE_ATTR{
132-
return SVE_ACLE_FUNC(svluti2_lane,_bf16,)(table, indices, 2);
132+
return SVE_ACLE_FUNC(svluti2_lane,_bf16)(table, indices, 2);
133133
}
134134

135135
// SME-CHECK-LABEL: @test_svluti4_lane_s8(
@@ -147,7 +147,7 @@ svbfloat16_t test_svluti2_lane_bf16(svbfloat16_t table, svuint8_t indices) MODE_
147147
// CPP-CHECK-NEXT: ret <vscale x 16 x i8> [[TMP0]]
148148
//
149149
svint8_t test_svluti4_lane_s8(svint8_t table, svuint8_t indices) MODE_ATTR{
150-
return SVE_ACLE_FUNC(svluti4_lane,_s8,)(table, indices, 0);
150+
return SVE_ACLE_FUNC(svluti4_lane,_s8)(table, indices, 0);
151151
}
152152

153153
// SME-CHECK-LABEL: @test_svluti4_lane_u8(
@@ -165,7 +165,7 @@ svint8_t test_svluti4_lane_s8(svint8_t table, svuint8_t indices) MODE_ATTR{
165165
// CPP-CHECK-NEXT: ret <vscale x 16 x i8> [[TMP0]]
166166
//
167167
svuint8_t test_svluti4_lane_u8(svuint8_t table, svuint8_t indices) MODE_ATTR{
168-
return SVE_ACLE_FUNC(svluti4_lane,_u8,)(table, indices, 1);
168+
return SVE_ACLE_FUNC(svluti4_lane,_u8)(table, indices, 1);
169169
}
170170

171171
// SME-CHECK-LABEL: @test_svluti4_lane_s16(
@@ -183,7 +183,7 @@ svuint8_t test_svluti4_lane_u8(svuint8_t table, svuint8_t indices) MODE_ATTR{
183183
// CPP-CHECK-NEXT: ret <vscale x 8 x i16> [[TMP0]]
184184
//
185185
svint16_t test_svluti4_lane_s16(svint16_t table, svuint8_t indices) MODE_ATTR{
186-
return SVE_ACLE_FUNC(svluti4_lane,_s16,)(table, indices, 0);
186+
return SVE_ACLE_FUNC(svluti4_lane,_s16)(table, indices, 0);
187187
}
188188

189189
// SME-CHECK-LABEL: @test_svluti4_lane_u16(
@@ -201,7 +201,7 @@ svint16_t test_svluti4_lane_s16(svint16_t table, svuint8_t indices) MODE_ATTR{
201201
// CPP-CHECK-NEXT: ret <vscale x 8 x i16> [[TMP0]]
202202
//
203203
svuint16_t test_svluti4_lane_u16(svuint16_t table, svuint8_t indices) MODE_ATTR{
204-
return SVE_ACLE_FUNC(svluti4_lane,_u16,)(table, indices, 3);
204+
return SVE_ACLE_FUNC(svluti4_lane,_u16)(table, indices, 3);
205205
}
206206

207207
// SME-CHECK-LABEL: @test_svluti4_lane_f16(
@@ -219,7 +219,7 @@ svuint16_t test_svluti4_lane_u16(svuint16_t table, svuint8_t indices) MODE_ATTR{
219219
// CPP-CHECK-NEXT: ret <vscale x 8 x half> [[TMP0]]
220220
//
221221
svfloat16_t test_svluti4_lane_f16(svfloat16_t table, svuint8_t indices) MODE_ATTR{
222-
return SVE_ACLE_FUNC(svluti4_lane,_f16,)(table, indices, 2);
222+
return SVE_ACLE_FUNC(svluti4_lane,_f16)(table, indices, 2);
223223
}
224224

225225
// SME-CHECK-LABEL: @test_svluti4_lane_bf16(
@@ -237,7 +237,7 @@ svfloat16_t test_svluti4_lane_f16(svfloat16_t table, svuint8_t indices) MODE_ATT
237237
// CPP-CHECK-NEXT: ret <vscale x 8 x bfloat> [[TMP0]]
238238
//
239239
svbfloat16_t test_svluti4_lane_bf16(svbfloat16_t table, svuint8_t indices) MODE_ATTR{
240-
return SVE_ACLE_FUNC(svluti4_lane,_bf16,)(table, indices, 1);
240+
return SVE_ACLE_FUNC(svluti4_lane,_bf16)(table, indices, 1);
241241
}
242242

243243
// SME-CHECK-LABEL: @test_svluti4_lane_s16_x2(
@@ -257,7 +257,7 @@ svbfloat16_t test_svluti4_lane_bf16(svbfloat16_t table, svuint8_t indices) MODE_
257257
// CPP-CHECK-NEXT: ret <vscale x 8 x i16> [[TMP0]]
258258
//
259259
svint16_t test_svluti4_lane_s16_x2(svint16x2_t table, svuint8_t indices) MODE_ATTR{
260-
return SVE_ACLE_FUNC(svluti4_lane,_s16,_x2)(table, indices, 0);
260+
return SVE_ACLE_FUNC(svluti4_lane,_s16_x2)(table, indices, 0);
261261
}
262262

263263
// SME-CHECK-LABEL: @test_svluti4_lane_u16_x2(
@@ -277,7 +277,7 @@ svint16_t test_svluti4_lane_s16_x2(svint16x2_t table, svuint8_t indices) MODE_AT
277277
// CPP-CHECK-NEXT: ret <vscale x 8 x i16> [[TMP0]]
278278
//
279279
svuint16_t test_svluti4_lane_u16_x2(svuint16x2_t table, svuint8_t indices) MODE_ATTR{
280-
return SVE_ACLE_FUNC(svluti4_lane,_u16,_x2)(table, indices, 3);
280+
return SVE_ACLE_FUNC(svluti4_lane,_u16_x2)(table, indices, 3);
281281
}
282282

283283
// SME-CHECK-LABEL: @test_svluti4_lane_f16_x2(
@@ -297,7 +297,7 @@ svuint16_t test_svluti4_lane_u16_x2(svuint16x2_t table, svuint8_t indices) MODE_
297297
// CPP-CHECK-NEXT: ret <vscale x 8 x half> [[TMP0]]
298298
//
299299
svfloat16_t test_svluti4_lane_f16_x2(svfloat16x2_t table, svuint8_t indices) MODE_ATTR{
300-
return SVE_ACLE_FUNC(svluti4_lane,_f16,_x2)(table, indices, 2);
300+
return SVE_ACLE_FUNC(svluti4_lane,_f16_x2)(table, indices, 2);
301301
}
302302

303303
// SME-CHECK-LABEL: @test_svluti4_lane_bf16_x2(
@@ -317,5 +317,5 @@ svfloat16_t test_svluti4_lane_f16_x2(svfloat16x2_t table, svuint8_t indices) MOD
317317
// CPP-CHECK-NEXT: ret <vscale x 8 x bfloat> [[TMP0]]
318318
//
319319
svbfloat16_t test_svluti4_lane_bf16_x2(svbfloat16x2_t table, svuint8_t indices) MODE_ATTR{
320-
return SVE_ACLE_FUNC(svluti4_lane,_bf16,_x2)(table, indices, 1);
320+
return SVE_ACLE_FUNC(svluti4_lane,_bf16_x2)(table, indices, 1);
321321
}

0 commit comments

Comments
 (0)