Addresses PR reviews

Author: badumbatish

llvm/lib/Analysis/ConstantFolding.cpp

@@ -3842,9 +3842,7 @@ static Constant *ConstantFoldFixedVectorCall(
       ConstantInt *Elt1 =
           cast<ConstantInt>(Operands[1]->getAggregateElement(I));
 
-      APInt IMul = Elt0->getValue().sext(32) * Elt1->getValue().sext(32);
-
-      MulVector[I] = IMul.getSExtValue();
+      MulVector[I] = Elt0->getSExtValue() * Elt1->getSExtValue();
     }
     for (unsigned I = 0; I < Result.size(); I++) {
       int32_t IAdd = MulVector[I * 2] + MulVector[I * 2 + 1];

llvm/test/Transforms/InstSimplify/ConstProp/WebAssembly/dot.ll

@@ -36,11 +36,7 @@ define <4 x i32> @dot_doubly_negative() {
   ret <4 x i32> %res
 }
 
-; This test checks for llvm's compliance on spec's wasm.dot's imul and iadd
-; Since the original number can only be i16::max == 2^15 - 1,
-;   subsequent modulo of 2^32 of imul and iadd
-;   should return the same result
-; 2*(2^15 - 1)^2 % 2^32 == 2*(2^15 - 1)^2
+; Tests that i16 max signed values fit in i32
 define <4 x i32> @dot_follow_modulo_spec_1() {
 ; CHECK-LABEL: define <4 x i32> @dot_follow_modulo_spec_1() {
 ; CHECK-NEXT:    ret <4 x i32> <i32 2147352578, i32 0, i32 0, i32 0>
@@ -49,9 +45,7 @@ define <4 x i32> @dot_follow_modulo_spec_1() {
   ret <4 x i32> %res
 }
 
-; This test checks for llvm's compliance on spec's wasm.dot's imul and iadd
-; 2*(- 2^15)^2 == 2^31, doesn't exceed 2^32 so we don't have to mod
-; wrapping around is -(2^31), still doesn't exceed 2^32
+; Tests that i16 min signed values fit in i32
 define <4 x i32> @dot_follow_modulo_spec_2() {
 ; CHECK-LABEL: define <4 x i32> @dot_follow_modulo_spec_2() {
 ; CHECK-NEXT:    ret <4 x i32> <i32 -2147483648, i32 0, i32 0, i32 0>