invert logic

Author: segoon

clang-tools-extra/clang-tidy/performance/LostStdMoveCheck.cpp

@@ -85,7 +85,7 @@ void LostStdMoveCheck::storeOptions(ClangTidyOptions::OptionMap &Opts) {
 
 LostStdMoveCheck::LostStdMoveCheck(StringRef Name, ClangTidyContext *Context)
     : ClangTidyCheck(Name, Context),
-      StrictMode(Options.get("StrictMode", true)) {}
+      StrictMode(Options.get("StrictMode", false)) {}
 
 void LostStdMoveCheck::registerMatchers(MatchFinder *Finder) {
   auto ReturnParent =
@@ -132,7 +132,7 @@ void LostStdMoveCheck::check(const MatchFinder::MatchResult &Result) {
     return;
   }
 
-  if (StrictMode) {
+  if (!StrictMode) {
     llvm::SmallPtrSet<const VarDecl *, 16> AllVarDecls =
         allVarDeclsExprs(*MatchedDecl, *MatchedFunc, *Result.Context);
     if (!AllVarDecls.empty()) {

clang-tools-extra/docs/clang-tidy/checks/performance/lost-std-move.rst

@@ -27,11 +27,11 @@ Also it does notice variable references "behind the scenes":
    void g(X x) {
      auto &y = x;
      f(x);  // does not emit a warning
-     y.f();  // because is still used
+     y.f();  // because x is still used via y
    }
 
 If you want to ignore assigns to reference variables, set ::option::
-`StrictMode` to `false`.
+`StrictMode` to `true`.
 
 
 Options
@@ -45,4 +45,4 @@ Options
    references ``X``, then it will not emit a warning for ``X`` not to provoke
    false positive. If you're sure that such references don't extend ``X``
    lifetime and ready to handle possible false positives, then set `StrictMode`
-   to `false`. Defaults to `true`.
+   to `true`. Defaults to `false`.

clang-tools-extra/test/clang-tidy/checkers/performance/lost-std-move-nonstrict.cpp renamed to clang-tools-extra/test/clang-tidy/checkers/performance/lost-std-move-strict.cpp

@@ -1,4 +1,4 @@
-// RUN: %check_clang_tidy %s performance-lost-std-move %t -- -config='{CheckOptions: {performance-lost-std-move.StrictMode: false}}'
+// RUN: %check_clang_tidy %s performance-lost-std-move %t -- -config='{CheckOptions: {performance-lost-std-move.StrictMode: true}}'
 
 namespace std {