Fix the bug and address comment

Author: grigorypas

llvm/lib/CodeGen/MachineFunctionSplitter.cpp

@@ -129,14 +129,17 @@ static bool isColdBlock(const MachineBasicBlock &MBB,
 }
 
 bool MachineFunctionSplitter::runOnMachineFunction(MachineFunction &MF) {
+  if (skipFunction(MF.getFunction()))
+    return false;
+
   // Do not split functions when -basic-block-sections=all is specified.
   if (MF.getTarget().getBBSectionsType() == llvm::BasicBlockSection::All)
     return false;
   // We target functions with profile data. Static information in the form
   // of exception handling code may be split to cold if user passes the
   // mfs-split-ehcode flag.
   bool UseProfileData = MF.getFunction().hasProfileData();
-  if (!skipFunction(MF.getFunction()) && !UseProfileData && !SplitAllEHCode)
+  if (!UseProfileData && !SplitAllEHCode)
     return false;
 
   const TargetInstrInfo &TII = *MF.getSubtarget().getInstrInfo();

llvm/test/CodeGen/Generic/machine-function-splitter-optnone.ll

@@ -1,6 +1,6 @@
 ; REQUIRES: x86-registered-target
 
-; RUN: llc < %s -mtriple=x86_64-unknown-linux-gnu -split-machine-functions | FileCheck %s
+; RUN: llc < %s -mtriple=x86_64-unknown-linux-gnu -split-machine-functions -O0 -mfs-psi-cutoff=0 -mfs-count-threshold=10000 | FileCheck %s
 
 ;; Check that functions with optnone attribute are not split.
 ; CHECK-LABEL: foo_optnone: