Skip to content

Commit 683fad8

Browse files
committed
address comments
1 parent 164e9d6 commit 683fad8

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

mlir/lib/Dialect/Vector/Transforms/VectorDistribute.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1760,7 +1760,7 @@ struct WarpOpScfForOp : public WarpDistributionPattern {
17601760
// Those Values need to be returned by the new warp op.
17611761
llvm::SmallSetVector<Value, 32> escapingValues;
17621762
SmallVector<Type> escapingValueInputTypes;
1763-
SmallVector<Type> escapingValuedistTypes;
1763+
SmallVector<Type> escapingValueDistTypes;
17641764
mlir::visitUsedValuesDefinedAbove(
17651765
forOp.getBodyRegion(), [&](OpOperand *operand) {
17661766
Operation *parent = operand->get().getParentRegion()->getParentOp();
@@ -1773,11 +1773,11 @@ struct WarpOpScfForOp : public WarpDistributionPattern {
17731773
distType = getDistributedType(vecType, map, warpOp.getWarpSize());
17741774
}
17751775
escapingValueInputTypes.push_back(operand->get().getType());
1776-
escapingValuedistTypes.push_back(distType);
1776+
escapingValueDistTypes.push_back(distType);
17771777
}
17781778
});
17791779

1780-
if (llvm::is_contained(escapingValuedistTypes, Type{}))
1780+
if (llvm::is_contained(escapingValueDistTypes, Type{}))
17811781
return failure();
17821782
// `WarpOp` can yield two types of values:
17831783
// 1. Values that are not results of the `ForOp`:
@@ -1821,8 +1821,8 @@ struct WarpOpScfForOp : public WarpDistributionPattern {
18211821
newWarpOpYieldValues.insert(newWarpOpYieldValues.end(),
18221822
escapingValues.begin(), escapingValues.end());
18231823
newWarpOpDistTypes.insert(newWarpOpDistTypes.end(),
1824-
escapingValuedistTypes.begin(),
1825-
escapingValuedistTypes.end());
1824+
escapingValueDistTypes.begin(),
1825+
escapingValueDistTypes.end());
18261826
// Next, we insert all non-`ForOp` yielded values and their distributed
18271827
// types. We also create a mapping between the non-`ForOp` yielded value
18281828
// index and the corresponding new `WarpOp` yield value index (needed to

0 commit comments

Comments
 (0)