Removing optional<bool> since they can just be skipped if not set.

Author: ashgti

lldb/tools/lldb-dap/Protocol.cpp

@@ -182,10 +182,10 @@ json::Value toJSON(const ErrorMessage &EM) {
       variables[var.first] = var.second;
     Result.insert({"variables", std::move(variables)});
   }
-  if (EM.sendTelemetry && *EM.sendTelemetry)
-    Result.insert({"sendTelemetry", *EM.sendTelemetry});
-  if (EM.showUser && *EM.showUser)
-    Result.insert({"showUser", *EM.showUser});
+  if (EM.sendTelemetry)
+    Result.insert({"sendTelemetry", EM.sendTelemetry});
+  if (EM.showUser)
+    Result.insert({"showUser", EM.showUser});
   if (EM.url)
     Result.insert({"url", EM.url});
   if (EM.urlLabel)

lldb/tools/lldb-dap/Protocol.h

@@ -204,8 +204,8 @@ struct ErrorMessage {
   uint64_t id;
   std::string format;
   std::optional<std::map<std::string, std::string>> variables;
-  std::optional<bool> sendTelemetry;
-  std::optional<bool> showUser;
+  bool sendTelemetry;
+  bool showUser;
   std::optional<std::string> url;
   std::optional<std::string> urlLabel;
 };