Verify entry block in SPIRV dialect

Author: hiraditya

mlir/lib/Dialect/SPIRV/IR/SPIRVOps.cpp

@@ -1021,6 +1021,14 @@ LogicalResult spirv::FuncOp::verifyType() {
 
 LogicalResult spirv::FuncOp::verifyBody() {
   FunctionType fnType = getFunctionType();
+  if (!isExternal()) {
+    Block &entryBlock = front();
+
+    unsigned numArguments = this->getNumArguments();
+    if (entryBlock.getNumArguments() != numArguments)
+      return emitOpError("entry block must have ")
+             << numArguments << " arguments to match function signature";
+  }
 
   auto walkResult = walk([fnType](Operation *op) -> WalkResult {
     if (auto retOp = dyn_cast<spirv::ReturnOp>(op)) {

mlir/test/Dialect/SPIRV/IR/func-entry.mlir

@@ -0,0 +1,12 @@
+// Bug: https://github.com/llvm/llvm-project/issues/132894
+
+// RUN: not mlir-opt %s 2>&1 | FileCheck %s
+
+// CHECK: error: 'spirv.func' op entry block must have 1 arguments to match function signature
+module {
+  spirv.func @f(f32) "None" {
+    %c0 = arith.constant 0 : index
+    spirv.Return
+  }
+}
+