[include-cleaner] warning when the deprecated commands are used

Author: hulxv

clang-tools-extra/include-cleaner/tool/IncludeCleaner.cpp

@@ -92,13 +92,13 @@ cl::opt<bool> Edit{
 };
 cl::opt<bool> Insert{
     "insert",
-    cl::desc("Allow header insertions"),
+    cl::desc("Allow header insertions (deprecated. Use -disable-insert instead)"),
     cl::init(true),
     cl::cat(IncludeCleaner),
 };
 cl::opt<bool> Remove{
     "remove",
-    cl::desc("Allow header removals"),
+    cl::desc("Allow header removals (deprecated. Use -disable-remove instead)"),
     cl::init(true),
     cl::cat(IncludeCleaner),
 };
@@ -194,6 +194,21 @@ class Action : public clang::ASTFrontendAction {
     auto Results =
         analyze(AST.Roots, PP.MacroReferences, PP.Includes, &PI,
                 getCompilerInstance().getPreprocessor(), HeaderFilter);
+
+    if (!Insert) {
+      llvm::errs() << "`-insert=0` is deprecated in favor of `-disable-insert`. "
+                      "The old flag was confusing since it suggested that inserts "
+                      "were disabled by default, when they were actually enabled. "
+                      "See https://github.com/llvm/llvm-project/pull/132991\n";
+    }
+
+    if (!Remove) {
+      llvm::errs() << "`-remove=0` is deprecated in favor of `-disable-remove`. "
+                      "The old flag was confusing since it suggested that removes "
+                      "were disabled by default, when they were actually enabled. "
+                      "See https://github.com/llvm/llvm-project/pull/132991\n";
+    }
+
     if (!Insert || DisableInsert)
       Results.Missing.clear();
     if (!Remove || DisableRemove)